From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10548 invoked by alias); 24 Feb 2006 02:02:40 -0000 Received: (qmail 10539 invoked by uid 22791); 24 Feb 2006 02:02:40 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Feb 2006 02:02:38 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id k1O22aZZ004234 for ; Thu, 23 Feb 2006 21:02:36 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id k1O22a117280; Thu, 23 Feb 2006 21:02:36 -0500 Received: from tortoise.toronto.redhat.com (tortoise.toronto.redhat.com [172.16.14.92]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id k1O22Zg2020417; Thu, 23 Feb 2006 21:02:35 -0500 Subject: Re: FYI: New Lightweight tests From: Thomas Fitzsimmons To: Lillian Angel Cc: David Gilbert , mauve-patches In-Reply-To: <1140632320.22215.92.camel@tow.toronto.redhat.com> References: <1140565958.22215.52.camel@tow.toronto.redhat.com> <43FC3D06.4060209@object-refinery.com> <1140629152.1404.204.camel@tortoise.toronto.redhat.com> <1140630448.22215.87.camel@tow.toronto.redhat.com> <1140632320.22215.92.camel@tow.toronto.redhat.com> Content-Type: text/plain Date: Fri, 24 Feb 2006 02:02:00 -0000 Message-Id: <1140746555.25046.52.camel@tortoise.toronto.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2006/txt/msg00176.txt.bz2 Hi, On Wed, 2006-02-22 at 13:18 -0500, Lillian Angel wrote: > I fixed up testLoc1 I don't see testLoc1 in gnu/testlet/java/awt/Container/LightweightContainer.java. > so it fails with Classpath (without my AWT patch). > I also adjusted some of the delays to be longer. It was causing race > conditions with my new test. > > 2006-02-22 Lillian Angel > > * gnu/testlet/java/awt/Container/LightweightContainer.java > (testLoc1): Fixed up tests so it fails without pending > lightweight patch. Did you mean testLoc2? The first check in testLoc2 fails on Sun and on JamVM with or without the lightweight patch. This location seems wrong: int x = LW.getX() + f.getInsets().left + p.x - 1; int y = pan.getY() + f.getInsets().top + p.y; since the bottom panel is inset from the left panel. Also, I think this test should be simplified. The test is: A Frame containing a lighweight container. The lightweight container contains a heavyweight child. The lightweight container is moved but not resized (so that the heavyweight's position changes relative to the frame but not relative to its parent). So the test should be: - show a Frame with a null layout and a green background, with lightweight child at a given size and location. inside that lightweight child, add a blue heavyweight panel - wait for a second - call Component.move on the lightweight child - check for the blue heavyweight panel's position relative to the frame Without our patch, the panel will not move and so will end up in the wrong location relative to the frame. With our patch it will move along with the lightweight container and end up in the right position. Tom