From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27629 invoked by alias); 13 Jun 2006 07:38:47 -0000 Received: (qmail 27615 invoked by uid 22791); 13 Jun 2006 07:38:46 -0000 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Jun 2006 07:38:43 +0000 Received: from elsschot.wildebeest.org ([192.168.1.26]) by gnu.wildebeest.org with esmtp (Exim 3.36 #1 (Debian)) id 1Fq3Uq-0005Rw-00; Tue, 13 Jun 2006 09:39:32 +0200 Subject: Re: FYI: Graphics2D.setTransform() test From: Mark Wielaard To: David Gilbert Cc: mauve-patches In-Reply-To: <44883B5F.8090207@object-refinery.com> References: <44883B5F.8090207@object-refinery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-mW/D+uPrZXfJJMx5hS8e" Date: Tue, 13 Jun 2006 07:38:00 -0000 Message-Id: <1150184321.4740.5.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2006/txt/msg00395.txt.bz2 --=-mW/D+uPrZXfJJMx5hS8e Content-Type: multipart/mixed; boundary="=-ZjJ6QgRlogLdhMtANeMD" --=-ZjJ6QgRlogLdhMtANeMD Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 805 Hi David, On Thu, 2006-06-08 at 15:59 +0100, David Gilbert wrote: > 2006-06-08 David Gilbert >=20 > * gnu/testlet/java/awt/Graphics2D/setTransform.java: New file, > * gnu/testlet/java/awt/Graphics2D/transform.java: New file. I changed these slightly to prevent some class cast exceptions. getClip() returns a Shape. And at least the GNU Classpath implementation sometimes just returns a GeneralPath instead of a Rectangle2D, probably a missed optimization, but I don't think it is actually wrong, even though the tests still fail of course. 2006-06-13 Mark Wielaard * gnu/testlet/java/awt/Graphics2D/setTransform.java: getClip() returns a Shape. * gnu/testlet/java/awt/Graphics2D/transform.java: Likewise. Committed, Mark --=-ZjJ6QgRlogLdhMtANeMD Content-Disposition: inline; filename=getClip-Shape.patch Content-Type: text/x-patch; name=getClip-Shape.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 Content-length: 3461 SW5kZXg6IGdudS90ZXN0bGV0L2phdmEvYXd0L0dyYXBoaWNzMkQvc2V0VHJh bnNmb3JtLmphdmENCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxl OiAvY3ZzL21hdXZlL21hdXZlL2dudS90ZXN0bGV0L2phdmEvYXd0L0dyYXBo aWNzMkQvc2V0VHJhbnNmb3JtLmphdmEsdg0KcmV0cmlldmluZyByZXZpc2lv biAxLjENCmRpZmYgLXUgLXIxLjEgc2V0VHJhbnNmb3JtLmphdmENCi0tLSBn bnUvdGVzdGxldC9qYXZhL2F3dC9HcmFwaGljczJEL3NldFRyYW5zZm9ybS5q YXZhCTggSnVuIDIwMDYgMTQ6NTc6MTkgLTAwMDAJMS4xDQorKysgZ251L3Rl c3RsZXQvamF2YS9hd3QvR3JhcGhpY3MyRC9zZXRUcmFuc2Zvcm0uamF2YQkx MyBKdW4gMjAwNiAwNzozNzoyNyAtMDAwMA0KQEAgLTI4LDYgKzI4LDcgQEAN CiBpbXBvcnQgZ251LnRlc3RsZXQuVGVzdGxldDsNCiANCiBpbXBvcnQgamF2 YS5hd3QuR3JhcGhpY3MyRDsNCitpbXBvcnQgamF2YS5hd3QuU2hhcGU7DQog aW1wb3J0IGphdmEuYXd0Lmdlb20uQWZmaW5lVHJhbnNmb3JtOw0KIGltcG9y dCBqYXZhLmF3dC5nZW9tLlJlY3RhbmdsZTJEOw0KIGltcG9ydCBqYXZhLmF3 dC5pbWFnZS5CdWZmZXJlZEltYWdlOw0KQEAgLTU1LDEzICs1NiwxMyBAQA0K ICAgICAvLyBzZXQuLi4NCiAgICAgaGFybmVzcy5jaGVjayhnMi5nZXRUcmFu c2Zvcm0oKSwgbmV3IEFmZmluZVRyYW5zZm9ybSgpKTsNCiAgICAgZzIuc2V0 Q2xpcCgxLCAyLCAzLCA0KTsNCi0gICAgUmVjdGFuZ2xlMkQgY3VycmVudENs aXAgPSAoUmVjdGFuZ2xlMkQpIGcyLmdldENsaXAoKTsNCisgICAgU2hhcGUg Y3VycmVudENsaXAgPSBnMi5nZXRDbGlwKCk7DQogICAgIGhhcm5lc3MuY2hl Y2soY3VycmVudENsaXAsIG5ldyBSZWN0YW5nbGUyRC5Eb3VibGUoMSwgMiwg MywgNCkpOw0KICAgICBnMi50cmFuc2Zvcm0oQWZmaW5lVHJhbnNmb3JtLmdl dFRyYW5zbGF0ZUluc3RhbmNlKDEwLjAsIDIwLjApKTsNCi0gICAgY3VycmVu dENsaXAgPSAoUmVjdGFuZ2xlMkQpIGcyLmdldENsaXAoKTsNCisgICAgY3Vy cmVudENsaXAgPSBnMi5nZXRDbGlwKCk7DQogICAgIGhhcm5lc3MuY2hlY2so Y3VycmVudENsaXAsIG5ldyBSZWN0YW5nbGUyRC5Eb3VibGUoLTksIC0xOCwg MywgNCkpOw0KICAgICBnMi5zZXRUcmFuc2Zvcm0obmV3IEFmZmluZVRyYW5z Zm9ybSgpKTsNCi0gICAgY3VycmVudENsaXAgPSAoUmVjdGFuZ2xlMkQpIGcy LmdldENsaXAoKTsNCisgICAgY3VycmVudENsaXAgPSBnMi5nZXRDbGlwKCk7 DQogICAgIGhhcm5lc3MuY2hlY2soY3VycmVudENsaXAsIG5ldyBSZWN0YW5n bGUyRC5Eb3VibGUoMSwgMiwgMywgNCkpOyAgICANCiAgIH0NCiB9DQpJbmRl eDogZ251L3Rlc3RsZXQvamF2YS9hd3QvR3JhcGhpY3MyRC90cmFuc2Zvcm0u amF2YQ0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9jdnMv bWF1dmUvbWF1dmUvZ251L3Rlc3RsZXQvamF2YS9hd3QvR3JhcGhpY3MyRC90 cmFuc2Zvcm0uamF2YSx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMQ0KZGlm ZiAtdSAtcjEuMSB0cmFuc2Zvcm0uamF2YQ0KLS0tIGdudS90ZXN0bGV0L2ph dmEvYXd0L0dyYXBoaWNzMkQvdHJhbnNmb3JtLmphdmEJOCBKdW4gMjAwNiAx NDo1NzoxOSAtMDAwMAkxLjENCisrKyBnbnUvdGVzdGxldC9qYXZhL2F3dC9H cmFwaGljczJEL3RyYW5zZm9ybS5qYXZhCTEzIEp1biAyMDA2IDA3OjM3OjI3 IC0wMDAwDQpAQCAtMjgsNiArMjgsNyBAQA0KIGltcG9ydCBnbnUudGVzdGxl dC5UZXN0bGV0Ow0KIA0KIGltcG9ydCBqYXZhLmF3dC5HcmFwaGljczJEOw0K K2ltcG9ydCBqYXZhLmF3dC5TaGFwZTsNCiBpbXBvcnQgamF2YS5hd3QuZ2Vv bS5BZmZpbmVUcmFuc2Zvcm07DQogaW1wb3J0IGphdmEuYXd0Lmdlb20uUmVj dGFuZ2xlMkQ7DQogaW1wb3J0IGphdmEuYXd0LmltYWdlLkJ1ZmZlcmVkSW1h Z2U7DQpAQCAtNjUsMTAgKzY2LDEwIEBADQogICAgIC8vIGFwcGxpZWQuLi4N CiAgICAgZzIuc2V0VHJhbnNmb3JtKG5ldyBBZmZpbmVUcmFuc2Zvcm0oKSk7 DQogICAgIGcyLnNldENsaXAoMSwgMiwgMywgNCk7DQotICAgIFJlY3Rhbmds ZTJEIGN1cnJlbnRDbGlwID0gKFJlY3RhbmdsZTJEKSBnMi5nZXRDbGlwKCk7 DQorICAgIFNoYXBlIGN1cnJlbnRDbGlwID0gZzIuZ2V0Q2xpcCgpOw0KICAg ICBoYXJuZXNzLmNoZWNrKGN1cnJlbnRDbGlwLCBuZXcgUmVjdGFuZ2xlMkQu RG91YmxlKDEsIDIsIDMsIDQpKTsNCiAgICAgZzIudHJhbnNmb3JtKEFmZmlu ZVRyYW5zZm9ybS5nZXRUcmFuc2xhdGVJbnN0YW5jZSgxMC4wLCAyMC4wKSk7 DQotICAgIGN1cnJlbnRDbGlwID0gKFJlY3RhbmdsZTJEKSBnMi5nZXRDbGlw KCk7DQorICAgIGN1cnJlbnRDbGlwID0gZzIuZ2V0Q2xpcCgpOw0KICAgICBo YXJuZXNzLmNoZWNrKGN1cnJlbnRDbGlwLCBuZXcgUmVjdGFuZ2xlMkQuRG91 YmxlKC05LCAtMTgsIDMsIDQpKTsNCiAgIH0NCiB9DQo= --=-ZjJ6QgRlogLdhMtANeMD-- --=-mW/D+uPrZXfJJMx5hS8e Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQBEjmuBxVhZCJWr9QwRAookAJ4unvdyHo4gOWfQoqAeUEqebXkl8QCfe9Lq 9eyNrYDX7Ghnw5f//qC5L+w= =rYdq -----END PGP SIGNATURE----- --=-mW/D+uPrZXfJJMx5hS8e--