From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mauve-patches-return-1198-listarch-mauve-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25366 invoked by alias); 26 Nov 2006 23:11:46 -0000
Received: (qmail 25356 invoked by uid 22791); 26 Nov 2006 23:11:46 -0000
X-Spam-Check-By: sourceware.org
Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 26 Nov 2006 23:11:41 +0000
Received: from dijkstra.wildebeest.org ([192.168.1.29]) 	by gnu.wildebeest.org with esmtp (Exim 3.36 #1 (Debian)) 	id 1GoTA9-0002vz-00 	for <mauve-patches@sources.redhat.com>; Mon, 27 Nov 2006 00:11:53 +0100
Subject: FYI: Improve stack trace output a little
From: Mark Wielaard <mark@klomp.org>
To: mauve-patches@sources.redhat.com
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-meIbFZItxysC9kj4XcpZ"
Date: Sun, 26 Nov 2006 23:11:00 -0000
Message-Id: <1164582695.10461.80.camel@dijkstra.wildebeest.org>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.3 (2.6.3-1.fc5.5)
X-IsSubscribed: yes
Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <mauve-patches.sourceware.org>
List-Subscribe: <mailto:mauve-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/mauve-patches/>
List-Post: <mailto:mauve-patches@sourceware.org>
List-Help: <mailto:mauve-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: mauve-patches-owner@sourceware.org
X-SW-Source: 2006/txt/msg00751.txt.bz2


--=-meIbFZItxysC9kj4XcpZ
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Content-length: 881

Hi,

We would only use the exception class name, but it is better to use the
whole exception, including the message.

2006-11-26  Mark Wielaard  <mark@klomp.org>

        * RunnerProcess.java (getStackTraceString): Use whole exception
        message, not just the class name.

Committed,

Mark

diff -u -r1.15 RunnerProcess.java
--- RunnerProcess.java  13 Oct 2006 11:45:42 -0000      1.15
+++ RunnerProcess.java  26 Nov 2006 23:09:10 -0000
@@ -395,7 +395,7 @@
   private static String getStackTraceString(Throwable ex, String pad)
   {
     StackTraceElement[] st =3D ex.getStackTrace();
-    StringBuffer sb =3D new StringBuffer(pad + ex.getClass().getName() + "=
\n");
+    StringBuffer sb =3D new StringBuffer(pad + ex.toString() + "\n");
     for (int i =3D 0; i < st.length; i++)
       sb.append(pad + "at " + st[i].toString() + "\n");
     sb.setLength(sb.length() - 1);


--=-meIbFZItxysC9kj4XcpZ
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
Content-length: 189

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQBFah8mxVhZCJWr9QwRAssRAJ9Ay0aBS8NfTFtZc+JklPLTfnmT/QCfRDjv
tMFDh/IyD/XLt8EYV3T4H14=
=DhvT
-----END PGP SIGNATURE-----

--=-meIbFZItxysC9kj4XcpZ--