From: Christian Thalinger <twisti@complang.tuwien.ac.at>
To: mauve-patches ml <mauve-patches@sourceware.org>
Subject: write XML output file only once
Date: Thu, 15 May 2008 10:36:00 -0000 [thread overview]
Message-ID: <1210847780.3214.24.camel@imac523d.theobroma-systems.com> (raw)
Hi!
This patch only writes the XML output file once after the Harness sends
"_dump_data_" and not after each finished testlet. This can be a huge
amount of data writes when running e.g. on java.util.
OK to commit?
- twisti
---
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.16
diff -u -3 -p -r1.16 RunnerProcess.java
--- RunnerProcess.java 26 Nov 2006 23:12:41 -0000 1.16
+++ RunnerProcess.java 15 May 2008 10:33:20 -0000
@@ -214,6 +214,21 @@ public class RunnerProcess
System.exit(0);
if (testname.equals("_dump_data_"))
{
+ // Print the report if necessary.
+ if (report != null)
+ {
+ File f = new File(xmlfile);
+ try
+ {
+ report.writeXml(f);
+ }
+ catch (IOException e)
+ {
+ throw new Error("Failed to write data to xml file: "
+ + e.getMessage());
+ }
+ }
+
if (useEMMA)
dumpCoverageData();
else
@@ -433,20 +448,6 @@ public class RunnerProcess
// Print out a summary.
int temp = harness.done();
- // Print the report if necessary.
- if (report != null)
- {
- File f = new File(xmlfile);
- try
- {
- report.writeXml(f);
- }
- catch (IOException e)
- {
- throw new Error("Failed to write data to xml file: "
- + e.getMessage());
- }
- }
// Report back to Harness that we've finished properly, whether the test
// passed or failed. Harness will wait for a message starting with
next reply other threads:[~2008-05-15 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 10:36 Christian Thalinger [this message]
2008-05-19 8:09 ` Christian Thalinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210847780.3214.24.camel@imac523d.theobroma-systems.com \
--to=twisti@complang.tuwien.ac.at \
--cc=mauve-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).