From: Christian Thalinger <twisti@complang.tuwien.ac.at>
To: mauve-patches ml <mauve-patches@sourceware.org>
Subject: fix missing failures in XML output
Date: Wed, 11 Jun 2008 10:07:00 -0000 [thread overview]
Message-ID: <1213178846.28056.15.camel@cthalinger.lan> (raw)
Hi!
This fixes missing failures in the XML output. Commited.
- twisti
---
Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.2112
diff -u -3 -p -r1.2112 ChangeLog
--- ChangeLog 9 Jun 2008 13:54:35 -0000 1.2112
+++ ChangeLog 11 Jun 2008 10:05:17 -0000
@@ -1,3 +1,9 @@
+2008-06-11 Christian Thalinger <twisti@complang.tuwien.ac.at>
+
+ * RunnerProcess.java (check(Object, Object)): Changed code so we
+ don't have early returns and miss currentResult.addFail() calls.
+ This fixes a bug in missing failures in the XML output.
+
2008-06-09 Christian Thalinger <twisti@complang.tuwien.ac.at>
* gnu/testlet/java/security/AccessController/contexts.java (test):
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.17
diff -u -3 -p -r1.17 RunnerProcess.java
--- RunnerProcess.java 19 May 2008 08:19:34 -0000 1.17
+++ RunnerProcess.java 11 Jun 2008 10:05:17 -0000
@@ -546,19 +546,19 @@ public class RunnerProcess
lastFailureMessage = "\n got " + gotString
+ "\n\n but expected " + expString
+ "\n\n";
- System.out.println(lastFailureMessage);
- return;
}
else
{
- lastFailureMessage = "Objects were not equal";
- System.out.println("objects were not equal. " +
- "Use -debug for more information.");
- return;
+ lastFailureMessage = "Objects were not equal. " +
+ "Use -debug for more information.";
}
}
- lastFailureMessage = "got " + gotString + " but expected " + expString;
- currentResult.addFail(desc + " -- " +lastFailureMessage);
+ else
+ {
+ lastFailureMessage =
+ "got " + gotString + " but expected " + expString;
+ }
+ currentResult.addFail(desc + " -- " + lastFailureMessage);
System.out.println(lastFailureMessage);
}
}
reply other threads:[~2008-06-11 10:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213178846.28056.15.camel@cthalinger.lan \
--to=twisti@complang.tuwien.ac.at \
--cc=mauve-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).