From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10598 invoked by alias); 23 Mar 2009 22:29:38 -0000 Received: (qmail 10573 invoked by uid 22791); 23 Mar 2009 22:29:38 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_40 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (80.101.103.228) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Mar 2009 22:29:33 +0000 Received: from shuttle.wildebeest.org ([192.168.1.1] helo=[127.0.0.1]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1Llse9-0001jZ-Te; Mon, 23 Mar 2009 23:29:30 +0100 Subject: Re: RFC: Fix java.awt.Dialog.size From: Mark Wielaard To: Omair Majid Cc: mauve-patches@sources.redhat.com In-Reply-To: <49C7F01D.5050909@redhat.com> References: <49C7F01D.5050909@redhat.com> Content-Type: text/plain Date: Mon, 23 Mar 2009 22:29:00 -0000 Message-Id: <1237847368.16095.57.camel@hermans.wildebeest.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2009/txt/msg00010.txt.bz2 Hi Omair, On Mon, 2009-03-23 at 16:25 -0400, Omair Majid wrote: > This patch fixes an issue in the java.awt.Dialog.size test where the > Dialog was shown and then a component was added to it, causing the > preferred size to become more than the actual size. > > Works with IcedTea6 and gij 4.3.2 > > Changelog: > 2009-03-23 Omair Majid > > * gnu/testlet/java/awt/Dialog/size.java (test): First add any > components to the Dialog, then pack it before testing preferred > size and actual size. The original version of this test had "Dialog should be shown at preferred size when pack is not called before show." Which is probably why pack() wasn't in the original. I am not sure that is a legal assumption though. So adding the pack() might be what is needed here. It depends on what you want to test. Maybe Lillian remembers, she added the test originally. Cheers, Mark