From: "Andrew John Hughes" <gnu_andrew@member.fsf.org>
To: mauve-patches@sources.redhat.com
Subject: FYI: Fix for InstantiateChild test
Date: Sun, 21 May 2006 20:30:00 -0000 [thread overview]
Message-ID: <20060521202908.GA7910@localhost.localdomain> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 944 bytes --]
I'm committing the attached patch which fixes a bug
in the recent InstantiateChild test; it shouldn't
compare the return value as we do with add.
Changelog:
2006-05-21 Andrew John Hughes <gnu_andrew@member.fsf.org>
* gnu/testlet/java/beans/beancontext/InstantiateChild.java:
Fix incorrect test of return value of InstantiateChild.
--
Andrew :-)
Please avoid sending me Microsoft Office (e.g. Word, PowerPoint) attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
If you use Microsoft Office, support movement towards the end of vendor lock-in:
http://opendocumentfellowship.org/petition/
"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman
Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }
[-- Attachment #1.2: beancontext-03b.diff --]
[-- Type: text/plain, Size: 1001 bytes --]
Index: gnu/testlet/java/beans/beancontext/InstantiateChild.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/beans/beancontext/InstantiateChild.java,v
retrieving revision 1.1
diff -u -3 -p -u -r1.1 InstantiateChild.java
--- gnu/testlet/java/beans/beancontext/InstantiateChild.java 21 May 2006 20:09:11 -0000 1.1
+++ gnu/testlet/java/beans/beancontext/InstantiateChild.java 21 May 2006 20:23:34 -0000
@@ -42,8 +42,7 @@ public class InstantiateChild
h.check(context.isEmpty(), "Empty check");
h.check(context.size() == 0, "Size of 0 check");
/* Add child */
- h.check(context.instantiateChild("java.beans.beancontext.BeanContextChildSupport"),
- "Child instantiated addition check");
+ context.instantiateChild("java.beans.beancontext.BeanContextChildSupport");
/* Check child is added to context */
h.check(context.isEmpty() == false, "Non-empty check");
h.check(context.size() == 1, "Size of 1 check");
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
reply other threads:[~2006-05-21 20:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060521202908.GA7910@localhost.localdomain \
--to=gnu_andrew@member.fsf.org \
--cc=mauve-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).