FYI: Fix RunnerProcess.removeSecurityManager()

FYI: Fix RunnerProcess.removeSecurityManager()

[Gary Benson]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

Hi all,

This commit fixes RunnerProcess.removeSecurityManager() to use the new
test security manager rather than the old one.  I also added a warning
message if it does find stray test security managers installed.

Cheers,
Gary

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1356 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.1743
diff -u -r1.1743 ChangeLog
--- ChangeLog	27 Jun 2006 12:23:37 -0000	1.1743
+++ ChangeLog	27 Jun 2006 15:13:25 -0000
@@ -1,3 +1,7 @@
+2006-06-27  Gary Benson  <gbenson@redhat.com>
+
+	* RunnerProcess.java (removeSecurityManager): Updated.
+
 2006-06-27  Gary Benson  <gbenson@redhat.com>
 
 	* gnu/testlet/TestSecurityManager.java: Replaced with a
Index: RunnerProcess.java
===================================================================
RCS file: /cvs/mauve/mauve/RunnerProcess.java,v
retrieving revision 1.8
diff -u -r1.8 RunnerProcess.java
--- RunnerProcess.java	19 Jun 2006 22:07:37 -0000	1.8
+++ RunnerProcess.java	27 Jun 2006 15:13:25 -0000
@@ -743,12 +743,13 @@
 
   private void removeSecurityManager()
   {
-    SecurityManager m = System.getSecurityManager();
-    if (m instanceof TestSecurityManager)
+    while (true)
       {
-        TestSecurityManager tsm = (TestSecurityManager) m;
-        tsm.setRunChecks(false);
-        System.setSecurityManager(null);
+	SecurityManager sm = System.getSecurityManager();
+	if (!(sm instanceof TestSecurityManager))
+	  break;
+	debug("warning: TestSecurityManager was not uninstalled");
+	((TestSecurityManager) sm).uninstall();
       }
   }