public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: mauve-patches@sources.redhat.com
Subject: FYI: Fix File.deleteOnExit() throwpoint check
Date: Tue, 18 Jul 2006 11:48:00 -0000	[thread overview]
Message-ID: <20060718114818.GC3038@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Hi all,

This commit fixes the File.deleteOnExit() throwpoint check on
Classpath, which performs some privileged checks that were not
being allowed.

Cheers,
Gary

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1686 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/mauve/mauve/ChangeLog,v
retrieving revision 1.1806
diff -u -r1.1806 ChangeLog
--- ChangeLog	17 Jul 2006 16:34:25 -0000	1.1806
+++ ChangeLog	18 Jul 2006 11:45:09 -0000
@@ -1,3 +1,7 @@
+2006-07-18  Gary Benson  <gbenson@redhat.com>
+
+	* gnu/testlet/java/io/File/security.java: Fix deleteOnExit test.
+
 2006-07-17  David Gilbert  <david.gilbert@object-refinery.com>
 
 	* gnu/testlet/java/awt/image/ComponentSampleModel/constructors.java: New file,
Index: gnu/testlet/java/io/File/security.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/java/io/File/security.java,v
retrieving revision 1.13
diff -u -r1.13 security.java
--- gnu/testlet/java/io/File/security.java	14 Jul 2006 10:13:56 -0000	1.13
+++ gnu/testlet/java/io/File/security.java	18 Jul 2006 11:45:09 -0000
@@ -82,6 +82,11 @@
     Permission tmpdirPropPerm =
       new PropertyPermission("java.io.tmpdir", "read");
 
+    Permission modifyThreadGroup =
+      new RuntimePermission("modifyThreadGroup");
+    Permission shutdownHooks =
+      new RuntimePermission("shutdownHooks");
+
     // Keep a record of created temp files so we can delete them later.
     File tf1 = null;
     File tf2 = null;
@@ -291,7 +296,8 @@
       // throwpoint: java.io.File-deleteOnExit-DIR
       harness.checkPoint("dir.deleteOnExit()");
       try {
-	sm.prepareChecks(new Permission[]{tmpdirDeletePerm});
+	sm.prepareChecks(new Permission[]{tmpdirDeletePerm},
+			 new Permission[]{modifyThreadGroup, shutdownHooks});
 	tmpdir.deleteOnExit();
 	sm.checkAllChecked();
       }

                 reply	other threads:[~2006-07-18 11:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060718114818.GC3038@redhat.com \
    --to=gbenson@redhat.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).