From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11219 invoked by alias); 14 Mar 2006 21:08:26 -0000 Received: (qmail 11210 invoked by uid 22791); 14 Mar 2006 21:08:25 -0000 X-Spam-Check-By: sourceware.org Received: from outmail128170.authsmtp.co.uk (HELO outmail128170.authsmtp.co.uk) (62.13.128.170) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 14 Mar 2006 21:08:24 +0000 Received: from [192.168.1.100] (cpc4-hem14-0-0-cust839.lutn.cable.ntl.com [86.5.111.72]) (authenticated bits=0) by squirrel.dmpriest.net.uk (8.13.3/8.13.3/Kp) with ESMTP id k2EL8K6X054058 for ; Tue, 14 Mar 2006 21:08:20 GMT (envelope-from david.gilbert@object-refinery.com) Message-ID: <44173217.8030501@object-refinery.com> Date: Tue, 14 Mar 2006 21:08:00 -0000 From: David Gilbert User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051026) MIME-Version: 1.0 To: mauve-patches@sources.redhat.com Subject: FYI: TableColumn.setMaxWidth() test enhanced Content-Type: multipart/mixed; boundary="------------030201000303090707070207" X-Server-Quench: aa6ac281-b39e-11da-b770-001185d377ca X-Authentic-SMTP: 61633132333134.squirrel.dmpriest.net.uk:1.47/Kp X-Powered-By: AuthSMTP - http://www.authsmtp.com - Authenticated SMTP Mail Relay X-Report-SPAM: If SPAM / abuse - report it at: http://www.authsmtp.com/abuse X-Virus-Status: No virus detected - but ensure you scan with your own anti-virus system! X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2006/txt/msg00239.txt.bz2 This is a multi-part message in MIME format. --------------030201000303090707070207 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 466 This patch (committed) extends the test for the TableColumn.setMaxWidth() method to check for the correct PropertyChangeEvent(s): 2006-03-14 David Gilbert * gnu/testlet/javax/swing/table/TableColumn/setMaxWidth.java (events): New field, (propertyChange): New method, (test): Added checks for PropertyChangeEvents. I will commit a patch to GNU Classpath CVS shortly to make these tests pass. Regards, Dave --------------030201000303090707070207 Content-Type: text/plain; name="diff.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff.txt" Content-length: 3468 Index: gnu/testlet/javax/swing/table/TableColumn/setMaxWidth.java =================================================================== RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/table/TableColumn/setMaxWidth.java,v retrieving revision 1.1 diff -u -r1.1 setMaxWidth.java --- gnu/testlet/javax/swing/table/TableColumn/setMaxWidth.java 9 Jan 2005 23:06:43 -0000 1.1 +++ gnu/testlet/javax/swing/table/TableColumn/setMaxWidth.java 14 Mar 2006 21:02:53 -0000 @@ -1,6 +1,6 @@ // Tags: JDK1.2 -// Copyright (C) 2005 David Gilbert +// Copyright (C) 2005, 2006, David Gilbert // Mauve is free software; you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by @@ -14,22 +14,33 @@ // You should have received a copy of the GNU General Public License // along with Mauve; see the file COPYING. If not, write to -// the Free Software Foundation, 59 Temple Place - Suite 330, -// Boston, MA 02111-1307, USA. */ +// the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, +// Boston, MA 02110-1301 USA. package gnu.testlet.javax.swing.table.TableColumn; import gnu.testlet.TestHarness; import gnu.testlet.Testlet; +import java.beans.PropertyChangeEvent; +import java.beans.PropertyChangeListener; +import java.util.List; + import javax.swing.table.TableColumn; /** * Some tests for the setMaxWidth() method in the {@link TableColumn} class. */ -public class setMaxWidth implements Testlet +public class setMaxWidth implements Testlet, PropertyChangeListener { + List events = new java.util.ArrayList(); + + public void propertyChange(PropertyChangeEvent e) + { + events.add(e); + } + /** * Runs the test using the specified harness. * @@ -38,15 +49,38 @@ public void test(TestHarness harness) { TableColumn c = new TableColumn(); + harness.check(c.getMaxWidth(), Integer.MAX_VALUE); + + c.addPropertyChangeListener(this); c.setMaxWidth(99); harness.check(c.getMaxWidth(), 99); + harness.check(events.size(), 1); + PropertyChangeEvent e = (PropertyChangeEvent) events.get(0); + harness.check(e.getPropertyName(), "maxWidth"); + harness.check(e.getOldValue(), new Integer(Integer.MAX_VALUE)); + harness.check(e.getNewValue(), new Integer(99)); + // now set the max width less than the current width and preferred width + events.clear(); harness.check(c.getWidth(), 75); harness.check(c.getPreferredWidth(), 75); c.setMaxWidth(50); harness.check(c.getWidth(), 50); harness.check(c.getMaxWidth(), 50); harness.check(c.getPreferredWidth(), 50); + harness.check(events.size(), 3); + PropertyChangeEvent e1 = (PropertyChangeEvent) events.get(0); + harness.check(e1.getPropertyName(), "width"); + harness.check(e1.getOldValue(), new Integer(75)); + harness.check(e1.getNewValue(), new Integer(50)); + PropertyChangeEvent e2 = (PropertyChangeEvent) events.get(1); + harness.check(e2.getPropertyName(), "preferredWidth"); + harness.check(e2.getOldValue(), new Integer(75)); + harness.check(e2.getNewValue(), new Integer(50)); + PropertyChangeEvent e3 = (PropertyChangeEvent) events.get(2); + harness.check(e3.getPropertyName(), "maxWidth"); + harness.check(e3.getOldValue(), new Integer(99)); + harness.check(e3.getNewValue(), new Integer(50)); } } --------------030201000303090707070207--