public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
* RFA JDWP TestOfClassMatchFilter
@ 2006-06-14 20:12 Kyle Galloway
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle Galloway @ 2006-06-14 20:12 UTC (permalink / raw)
  To: mauve-patches

[-- Attachment #1: Type: text/plain, Size: 113 bytes --]

Test for ClassMatchFilter from JDWP.  Requesting approval, and commit
since I don't have access.

Thanks,

Kyle


[-- Attachment #2: patch.diff --]
[-- Type: text/x-patch, Size: 4580 bytes --]

Index: gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java
===================================================================
RCS file: gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java
diff -N gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java	1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,130 @@
+/* TestOfClassMatchFilter.java -- test of ClassMatchFilter
+
+ Written by Kyle Galloway (kgallowa@redhat.com)
+
+ This file is part of Mauve.
+
+ Mauve is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
+ Mauve is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with Mauve; see the file COPYING.  If not, write to the
+ Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ 02110-1301 USA.
+
+ */
+
+// Tags: JDK1.4
+
+package gnu.testlet.gnu.classpath.jdwp.event.filters;
+
+import gnu.classpath.jdwp.event.ClassPrepareEvent;
+import gnu.classpath.jdwp.event.filters.ClassMatchFilter;
+import gnu.classpath.jdwp.exception.InvalidStringException;
+
+import gnu.testlet.TestHarness;
+import gnu.testlet.Testlet;
+
+/**
+ * @author Kyle Galloway (kgallowa@redhat.com)
+ * 
+ * This class performs a test of the <code>ClassMatchFilter</code>
+ * from JDWP.
+ */
+public class TestOfClassMatchFilter implements Testlet {
+
+	/**
+	 * Tests the <code>ClassMatchFilter</code> constructor
+	 * 
+	 * @param harness the TestHarness to use
+	 */
+	public void testConstructor(TestHarness harness) {
+		harness.checkPoint("Constructor");
+
+		ClassMatchFilter testCMF = null;
+
+		String[] validStrings = { "SomeString", "", "*omeString", "SomeStr*" };
+		String[] invalidStrings = { "Som*String", "SomeStri*g" };
+
+		// check to see if the valid strings don't throw exceptions
+		for (int i = 0; i < validStrings.length; i++) {
+			try {
+				testCMF = new ClassMatchFilter(validStrings[i]);
+				harness.check(true);
+			} catch (InvalidStringException ex) {
+				harness.check(false, "constructor threw exception for valid "
+						+ "string: " + validStrings[i]);
+			}
+		}
+
+		// check that invalid strings throw exceptions
+		for (int i = 0; i < invalidStrings.length; i++) {
+			try {
+				testCMF = new ClassMatchFilter(invalidStrings[i]);
+				harness.check(false, "constructor didn't throw exception for "
+						+ "invalid string: " + invalidStrings[i]);
+			} catch (InvalidStringException ex) {
+				harness.check(true);
+			}
+		}
+	}
+
+	/**
+	 * Tests the <code>ClassMatchFilter</code> method matches
+	 * 
+	 * @param harness the TestHarness to use
+	 */
+	public void testMatches(TestHarness harness) {
+		harness.checkPoint("matches method");
+		String[] validStrings = { "java.lang.Integer", "*nteger",
+				"java.lang.*", "*" };
+		String[] invalidStrings = { "Float", "Double", "AWT" };
+
+		ClassMatchFilter testCMF = null;
+
+		// create an event to use as a test
+		ClassPrepareEvent testEvent = new ClassPrepareEvent(Thread
+				.currentThread(), Integer.class, 0);
+		// check to see that the matching strings match the class name
+		for (int i = 0; i < validStrings.length; i++) {
+			try {
+				testCMF = new ClassMatchFilter(validStrings[i]);
+				harness.check(testCMF.matches(testEvent), true, "for string: "
+						+ validStrings[i]);
+			} catch (InvalidStringException ex) {
+				harness.check(false, "valid String: " + validStrings[i]
+						+ " threw " + ex);
+			}
+		}
+
+		// check to see that the nonmatching strings don't match the class name
+		for (int i = 0; i < invalidStrings.length; i++) {
+			try {
+				testCMF = new ClassMatchFilter(invalidStrings[i]);
+				harness.check(testCMF.matches(testEvent), false, "for string: "
+						+ invalidStrings[i]);
+			} catch (InvalidStringException ex) {
+				harness.check(false, "valid String: " + invalidStrings[i]
+						+ " threw " + ex);
+			}
+		}
+	}
+
+	/**
+	 * Test the <code>ClassMatchFilter</code> class
+	 * 
+	 * @param harness the TestHarness to use
+	 */
+	public void test(TestHarness harness) {
+		testConstructor(harness);
+		testMatches(harness);
+	}
+
+}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* RFA JDWP TestOfClassMatchFilter
@ 2006-06-15 14:22 Kyle Galloway
  0 siblings, 0 replies; 2+ messages in thread
From: Kyle Galloway @ 2006-06-15 14:22 UTC (permalink / raw)
  To: mauve-patches

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

Test for ClassMatchFilter from JDWP.  Requesting approval, and commit
since I don't have access.  Must have been half asleep last time 
formatting was wrong, and I forgot a changelog.

Thanks,

Kyle

2006-06-15  Kyle Galloway  <kgallowa@redhat.com>

    * gnu/testlet/gnu/classpath/jdwp/event/filters/
      ClassMatchFilter.java: New Test.



[-- Attachment #2: classmatchfilter.patch --]
[-- Type: text/x-patch, Size: 5255 bytes --]

Index: gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java
===================================================================
RCS file: gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java
diff -N gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ gnu/testlet/gnu/classpath/jdwp/event/filters/TestOfClassMatchFilter.java	1 Jan 1970 00:00:00 -0000
@@ -0,0 +1,150 @@
+/* TestOfClassMatchFilter.java -- test of ClassMatchFilter
+
+ Written by Kyle Galloway (kgallowa@redhat.com)
+
+ This file is part of Mauve.
+
+ Mauve is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2, or (at your option)
+ any later version.
+
+ Mauve is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with Mauve; see the file COPYING.  If not, write to the
+ Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+ 02110-1301 USA.
+
+ */
+
+// Tags: JDK1.4
+
+
+package gnu.testlet.gnu.classpath.jdwp.event.filters;
+
+import gnu.classpath.jdwp.event.ClassPrepareEvent;
+import gnu.classpath.jdwp.event.filters.ClassMatchFilter;
+import gnu.classpath.jdwp.exception.InvalidStringException;
+
+import gnu.testlet.TestHarness;
+import gnu.testlet.Testlet;
+
+/**
+ * @author Kyle Galloway (kgallowa@redhat.com) This class performs a test of the
+ *         <code>ClassMatchFilter</code> from JDWP.
+ */
+public class TestOfClassMatchFilter
+    implements Testlet
+{
+
+  /**
+   * Tests the <code>ClassMatchFilter</code> constructor
+   * 
+   * @param harness the TestHarness to use
+   */
+  public void testConstructor(TestHarness harness)
+  {
+    harness.checkPoint("Constructor");
+
+    ClassMatchFilter testCMF = null;
+
+    String[] validStrings = { "SomeString", "", "*omeString", "SomeStr*" };
+    String[] invalidStrings = { "Som*String", "SomeStri*g" };
+
+    // check to see if the valid strings don't throw exceptions
+    for (int i = 0; i < validStrings.length; i++)
+      {
+        try
+          {
+            testCMF = new ClassMatchFilter(validStrings[i]);
+            harness.check(true);
+          }
+        catch (InvalidStringException ex)
+          {
+            harness.check(false, "constructor threw exception for valid "
+                                 + "string: " + validStrings[i]);
+          }
+      }
+
+    // check that invalid strings throw exceptions
+    for (int i = 0; i < invalidStrings.length; i++)
+      {
+        try
+          {
+            testCMF = new ClassMatchFilter(invalidStrings[i]);
+            harness.check(false, "constructor didn't throw exception for "
+                                 + "invalid string: " + invalidStrings[i]);
+          }
+        catch (InvalidStringException ex)
+          {
+            harness.check(true);
+          }
+      }
+  }
+
+  /**
+   * Tests the <code>ClassMatchFilter</code> method matches
+   * 
+   * @param harness the TestHarness to use
+   */
+  public void testMatches(TestHarness harness)
+  {
+    harness.checkPoint("matches method");
+    String[] validStrings = { "java.lang.Integer", "*nteger", "java.lang.*",
+                             "*" };
+    String[] invalidStrings = { "Float", "Double", "AWT" };
+
+    ClassMatchFilter testCMF = null;
+
+    // create an event to use as a test
+    ClassPrepareEvent testEvent = new ClassPrepareEvent(Thread.currentThread(),
+                                                        Integer.class, 0);
+    // check to see that the matching strings match the class name
+    for (int i = 0; i < validStrings.length; i++)
+      {
+        try
+          {
+            testCMF = new ClassMatchFilter(validStrings[i]);
+            harness.check(testCMF.matches(testEvent), true, "for string: "
+                                                            + validStrings[i]);
+          }
+        catch (InvalidStringException ex)
+          {
+            harness.check(false, "valid String: " + validStrings[i] + " threw "
+                                 + ex);
+          }
+      }
+
+    // check to see that the nonmatching strings don't match the class name
+    for (int i = 0; i < invalidStrings.length; i++)
+      {
+        try
+          {
+            testCMF = new ClassMatchFilter(invalidStrings[i]);
+            harness.check(testCMF.matches(testEvent), false,
+                          "for string: " + invalidStrings[i]);
+          }
+        catch (InvalidStringException ex)
+          {
+            harness.check(false, "valid String: " + invalidStrings[i]
+                                 + " threw " + ex);
+          }
+      }
+  }
+
+  /**
+   * Test the <code>ClassMatchFilter</code> class
+   * 
+   * @param harness the TestHarness to use
+   */
+  public void test(TestHarness harness)
+  {
+    testConstructor(harness);
+    testMatches(harness);
+  }
+
+}

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-06-15 14:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-14 20:12 RFA JDWP TestOfClassMatchFilter Kyle Galloway
2006-06-15 14:22 Kyle Galloway

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).