public inbox for mauve-patches@sourceware.org
 help / color / mirror / Atom feed
From: David Gilbert <david.gilbert@object-refinery.com>
To: mauve-patches <mauve-patches@sources.redhat.com>
Subject: FYI: DefaultButtonModel.setSelected update
Date: Fri, 16 Jun 2006 13:51:00 -0000	[thread overview]
Message-ID: <4492B7C9.5030808@object-refinery.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

This patch (committed) updates the setSelected.java test to cover a 
minor bug in GNU Classpath:

2006-06-16  David Gilbert  <david.gilbert@object-refinery.com>

    * gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java
    (lastItemEvent): New field,
    (itemChanged): New method,
    (test): Check for required item event.

I already committed a patch to GNU Classpath to make this test pass.

Regards,

Dave

[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 2100 bytes --]

Index: gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java,v
retrieving revision 1.1
diff -u -r1.1 setSelected.java
--- gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java	16 May 2006 21:59:52 -0000	1.1
+++ gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java	16 Jun 2006 13:47:21 -0000
@@ -30,17 +30,22 @@
 
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
+import java.awt.event.ItemEvent;
+import java.awt.event.ItemListener;
 
 import javax.swing.DefaultButtonModel;
 import javax.swing.event.ChangeEvent;
 import javax.swing.event.ChangeListener;
 
-public class setSelected implements Testlet, ActionListener, ChangeListener
+public class setSelected 
+  implements Testlet, ActionListener, ChangeListener, ItemListener
 {
   ChangeEvent lastChangeEvent;
   
   ActionEvent lastActionEvent;
   
+  ItemEvent lastItemEvent;
+  
   public void stateChanged(ChangeEvent e) {
     lastChangeEvent = e;
   }
@@ -49,20 +54,30 @@
     lastActionEvent = e;
   }
 
+  public void itemStateChanged(ItemEvent e) 
+  {
+    lastItemEvent = e;
+  }
+  
   public void test(TestHarness harness) 
   {
     DefaultButtonModel m = new DefaultButtonModel();
     m.addActionListener(this);
     m.addChangeListener(this);
+    m.addItemListener(this);
     m.setSelected(true);
     harness.check(m.isSelected(), true);
     harness.check(lastChangeEvent.getSource(), m);
     harness.check(lastActionEvent, null);
+    harness.check(lastItemEvent.getSource(), m);
+    harness.check(lastItemEvent.getItem(), m);
     
     // setting the same again causes no event
     lastChangeEvent = null;
+    lastItemEvent = null;
     m.setSelected(true);
     harness.check(lastChangeEvent, null);
+    harness.check(lastItemEvent, null);
     
     // are the states independent?  Seems so.
     m.setPressed(true);
@@ -72,4 +87,6 @@
     m.setEnabled(true);
     harness.check(m.isSelected(), true);
   }
+
+
 }

                 reply	other threads:[~2006-06-16 13:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4492B7C9.5030808@object-refinery.com \
    --to=david.gilbert@object-refinery.com \
    --cc=mauve-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).