FYI: DefaultButtonModel.setSelected update

FYI: DefaultButtonModel.setSelected update

[David Gilbert]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

This patch (committed) updates the setSelected.java test to cover a 
minor bug in GNU Classpath:

2006-06-16  David Gilbert  <david.gilbert@object-refinery.com>

    * gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java
    (lastItemEvent): New field,
    (itemChanged): New method,
    (test): Check for required item event.

I already committed a patch to GNU Classpath to make this test pass.

Regards,

Dave

[-- Attachment #2: diff.txt --]
[-- Type: text/plain, Size: 2100 bytes --]

Index: gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java
===================================================================
RCS file: /cvs/mauve/mauve/gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java,v
retrieving revision 1.1
diff -u -r1.1 setSelected.java
--- gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java	16 May 2006 21:59:52 -0000	1.1
+++ gnu/testlet/javax/swing/DefaultButtonModel/setSelected.java	16 Jun 2006 13:47:21 -0000
@@ -30,17 +30,22 @@
 
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
+import java.awt.event.ItemEvent;
+import java.awt.event.ItemListener;
 
 import javax.swing.DefaultButtonModel;
 import javax.swing.event.ChangeEvent;
 import javax.swing.event.ChangeListener;
 
-public class setSelected implements Testlet, ActionListener, ChangeListener
+public class setSelected 
+  implements Testlet, ActionListener, ChangeListener, ItemListener
 {
   ChangeEvent lastChangeEvent;
   
   ActionEvent lastActionEvent;
   
+  ItemEvent lastItemEvent;
+  
   public void stateChanged(ChangeEvent e) {
     lastChangeEvent = e;
   }
@@ -49,20 +54,30 @@
     lastActionEvent = e;
   }
 
+  public void itemStateChanged(ItemEvent e) 
+  {
+    lastItemEvent = e;
+  }
+  
   public void test(TestHarness harness) 
   {
     DefaultButtonModel m = new DefaultButtonModel();
     m.addActionListener(this);
     m.addChangeListener(this);
+    m.addItemListener(this);
     m.setSelected(true);
     harness.check(m.isSelected(), true);
     harness.check(lastChangeEvent.getSource(), m);
     harness.check(lastActionEvent, null);
+    harness.check(lastItemEvent.getSource(), m);
+    harness.check(lastItemEvent.getItem(), m);
     
     // setting the same again causes no event
     lastChangeEvent = null;
+    lastItemEvent = null;
     m.setSelected(true);
     harness.check(lastChangeEvent, null);
+    harness.check(lastItemEvent, null);
     
     // are the states independent?  Seems so.
     m.setPressed(true);
@@ -72,4 +87,6 @@
     m.setEnabled(true);
     harness.check(m.isSelected(), true);
   }
+
+
 }