From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19851 invoked by alias); 10 Jul 2007 14:03:48 -0000 Received: (qmail 19841 invoked by uid 22791); 10 Jul 2007 14:03:47 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 10 Jul 2007 14:03:44 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6AE3for012807 for ; Tue, 10 Jul 2007 10:03:41 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6AE3eKI001787 for ; Tue, 10 Jul 2007 10:03:41 -0400 Received: from to-dhcp16.toronto.redhat.com (to-dhcp16.toronto.redhat.com [172.16.14.116]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l6AE3eij007190 for ; Tue, 10 Jul 2007 10:03:40 -0400 Message-ID: <469391BC.8030401@redhat.com> Date: Tue, 10 Jul 2007 14:03:00 -0000 From: Joshua Sumali User-Agent: Thunderbird 2.0.0.4 (X11/20070615) MIME-Version: 1.0 To: mauve-patches@sources.redhat.com Subject: FYI: Test Fix Content-Type: multipart/mixed; boundary="------------050804040108040804030709" X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2007/txt/msg00046.txt.bz2 This is a multi-part message in MIME format. --------------050804040108040804030709 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 408 This patch fixed an incorrect test in gnu/testlet/java/beans/Expression/check.java A test in Expression was looking for a return value for the Array.set method, but should not be since the method is public static void. Test now passes for java 1.4.2 and 1.5. 2007-07-10 Joshua Sumali * gnu/testlet/java/beans/Expression/check.java: (test): Fixed incorrect test. --------------050804040108040804030709 Content-Type: text/x-patch; name="patch.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch.diff" Content-length: 859 ### Eclipse Workspace Patch 1.0 #P mauve Index: gnu/testlet/java/beans/Expression/check.java =================================================================== RCS file: /cvs/mauve/mauve/gnu/testlet/java/beans/Expression/check.java,v retrieving revision 1.2 diff -u -r1.2 check.java --- gnu/testlet/java/beans/Expression/check.java 4 Jul 2004 15:58:18 -0000 1.2 +++ gnu/testlet/java/beans/Expression/check.java 10 Jul 2007 13:49:52 -0000 @@ -145,9 +145,9 @@ { harness.fail("Expression set failed"); } - harness.check(res4 instanceof Integer); - harness.check(((Integer)res4).intValue() == 3, - "Test Expression of array and method named set"); + //Array.set is public static void and should have no return value + harness.check(res4 == null); + harness.check(iarray[2] == 6); Object arg5[] = { new Integer(2) }; --------------050804040108040804030709--