From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26511 invoked by alias); 24 Jul 2007 20:17:05 -0000 Received: (qmail 26503 invoked by uid 22791); 24 Jul 2007 20:17:04 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.dnsmadeeasy.com (HELO smtp1.dnsmadeeasy.com) (205.234.170.134) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jul 2007 20:17:02 +0000 Received: from smtp1.dnsmadeeasy.com (localhost [127.0.0.1]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP id 5179530507D; Tue, 24 Jul 2007 20:16:59 +0000 (UTC) X-Authenticated-Name: js.dnsmadeeasy X-Transit-System: In case of SPAM please contact abuse@dnsmadeeasy.com Received: from avtrex.com (unknown [67.116.42.147]) by smtp1.dnsmadeeasy.com (Postfix) with ESMTP; Tue, 24 Jul 2007 20:16:59 +0000 (UTC) Received: from [192.168.7.26] ([192.168.7.26]) by avtrex.com with Microsoft SMTPSVC(6.0.3790.1830); Tue, 24 Jul 2007 13:16:58 -0700 Message-ID: <46A65E3A.4060101@avtrex.com> Date: Tue, 24 Jul 2007 20:17:00 -0000 From: David Daney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Joshua Sumali Cc: mauve-patches@sources.redhat.com Subject: Re: FYI: Test Fix References: <46A5FE5E.3080603@redhat.com> In-Reply-To: <46A5FE5E.3080603@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2007/txt/msg00052.txt.bz2 Joshua Sumali wrote: > This small patch fixes the timeout test in > gnu/testlet/java/net/HttpURLConnection/ > > The test now passes on jamvm and openjdk. > > 2007-07-24 Joshua Sumali > > * gnu/testlet/java/net/HttpURLConnection/timeout.java: > (testConnectTimeout): Fixed test. > > > > ------------------------------------------------------------------------ > > #P mauve > Index: gnu/testlet/java/net/HttpURLConnection/timeout.java > =================================================================== > RCS file: /cvs/mauve/mauve/gnu/testlet/java/net/HttpURLConnection/timeout.java,v > retrieving revision 1.1 > diff -u -r1.1 timeout.java > --- gnu/testlet/java/net/HttpURLConnection/timeout.java 8 Dec 2006 06:43:58 -0000 1.1 > +++ gnu/testlet/java/net/HttpURLConnection/timeout.java 24 Jul 2007 13:17:57 -0000 > @@ -248,7 +248,7 @@ > // It should timeout. > long end = System.currentTimeMillis(); > long delta = end - start; > - h.check((delta > 2000) && (delta < 5000)); > + h.check((delta > 0) && (delta < 5000)); > } > } > catch (IOException e) I wonder if this could have been caused by the extra ':' in the url on line 233. Could you try changing the url from "http://10.20.30.40:/foo" to "http://10.20.30.40/foo", and see if that fixes the problem instead? If not, I think the change you made is sensible. Thanks David Daney