From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25635 invoked by alias); 19 Feb 2009 19:44:19 -0000 Received: (qmail 25627 invoked by uid 22791); 19 Feb 2009 19:44:19 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_74,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Feb 2009 19:44:12 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n1JJiARE010564 for ; Thu, 19 Feb 2009 14:44:10 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1JJi6Jg015584 for ; Thu, 19 Feb 2009 14:44:06 -0500 Received: from toddler.yyz.redhat.com (toddler.yyz.redhat.com [10.15.16.34]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1JJi9Zs024131; Thu, 19 Feb 2009 14:44:10 -0500 Message-ID: <499DB67D.7090003@redhat.com> Date: Thu, 19 Feb 2009 19:44:00 -0000 From: Omair Majid User-Agent: Thunderbird 2.0.0.19 (X11/20090105) MIME-Version: 1.0 To: Lillian Angel CC: mauve-patches@sources.redhat.com Subject: Re: [PATCH] Output xml results for tests with compilation problems References: <499ACDAB.1070805@redhat.com> <499DACD4.8030104@redhat.com> In-Reply-To: <499DACD4.8030104@redhat.com> Content-Type: multipart/mixed; boundary="------------010300010402060303030700" X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2009/txt/msg00008.txt.bz2 This is a multi-part message in MIME format. --------------010300010402060303030700 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 354 Lillian Angel wrote: > Omair Majid wrote: >> The attached patch fixes mauve so that a failure is reported in the xml >> file. > > > Feel free to commit this. > Thanks. Applied patch as 2009-02-19 Omair Majid * RunnerProcess (runtest): If a test fails to start, include it in the xml report as a failure. Cheers, Omair --------------010300010402060303030700 Content-Type: text/plain; name="xmloutput.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="xmloutput.patch" Content-length: 1189 ? xmloutput-on-failed-to-compile-tests.patch ? xmloutput.patch Index: ChangeLog =================================================================== RCS file: /cvs/mauve/mauve/ChangeLog,v retrieving revision 1.2136 diff -u -r1.2136 ChangeLog --- ChangeLog 13 Feb 2009 15:51:58 -0000 1.2136 +++ ChangeLog 19 Feb 2009 19:37:11 -0000 @@ -1,3 +1,8 @@ +2009-02-19 Omair Majid + + * RunnerProcess (runtest): If a test fails to start, include it in the xml + report as a failure. + 2009-02-13 Omair Majid * Harness.java (setupHarness): Check for -xmlout file argument. Index: RunnerProcess.java =================================================================== RCS file: /cvs/mauve/mauve/RunnerProcess.java,v retrieving revision 1.18 diff -u -r1.18 RunnerProcess.java --- RunnerProcess.java 11 Jun 2008 10:08:00 -0000 1.18 +++ RunnerProcess.java 19 Feb 2009 19:37:11 -0000 @@ -362,6 +362,10 @@ if (verbose) System.out.println("TEST FAILED: exception when loading " + stripPrefix(name)); + + if (report != null) + report.addTestResult(currentResult); + return; } --------------010300010402060303030700--