From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26022 invoked by alias); 23 Mar 2009 20:26:23 -0000 Received: (qmail 26009 invoked by uid 22791); 23 Mar 2009 20:26:22 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_05,J_CHICKENPOX_44,J_CHICKENPOX_63,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Mar 2009 20:26:16 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n2NKQEZi007417 for ; Mon, 23 Mar 2009 16:26:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2NKQIts027468 for ; Mon, 23 Mar 2009 16:26:18 -0400 Received: from toddler.yyz.redhat.com (toddler.yyz.redhat.com [10.15.16.34]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2NKQDE1024590 for ; Mon, 23 Mar 2009 16:26:14 -0400 Message-ID: <49C7F01D.5050909@redhat.com> Date: Mon, 23 Mar 2009 20:26:00 -0000 From: Omair Majid User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: mauve-patches@sources.redhat.com Subject: RFC: Fix java.awt.Dialog.size Content-Type: multipart/mixed; boundary="------------000805060808050803040809" X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2009/txt/msg00009.txt.bz2 This is a multi-part message in MIME format. --------------000805060808050803040809 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 450 This patch fixes an issue in the java.awt.Dialog.size test where the Dialog was shown and then a component was added to it, causing the preferred size to become more than the actual size. Works with IcedTea6 and gij 4.3.2 Changelog: 2009-03-23 Omair Majid * gnu/testlet/java/awt/Dialog/size.java (test): First add any components to the Dialog, then pack it before testing preferred size and actual size. Cheers, Omair --------------000805060808050803040809 Content-Type: text/x-patch; name="dialog-size.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dialog-size.patch" Content-length: 667 Index: gnu/testlet/java/awt/Dialog/size.java =================================================================== RCS file: /cvs/mauve/mauve/gnu/testlet/java/awt/Dialog/size.java,v retrieving revision 1.2 diff -u -r1.2 size.java --- gnu/testlet/java/awt/Dialog/size.java 2 Nov 2005 16:38:22 -0000 1.2 +++ gnu/testlet/java/awt/Dialog/size.java 23 Mar 2009 20:11:13 -0000 @@ -37,8 +37,9 @@ public void test(TestHarness harness) { Dialog jd = new Dialog(new Frame()); - jd.show(); jd.add(new Label("Hello world")); + jd.pack(); + jd.show(); // jd insets may be larger than preferred size Dimension pref = jd.getPreferredSize(); --------------000805060808050803040809--