From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21663 invoked by alias); 5 Jun 2006 20:56:06 -0000 Received: (qmail 21653 invoked by uid 22791); 5 Jun 2006 20:56:05 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Jun 2006 20:55:33 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k55KtVOX019817 for ; Mon, 5 Jun 2006 16:55:31 -0400 Received: from opsy.redhat.com (vpn50-186.rdu.redhat.com [172.16.50.186]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k55KtVtH029241; Mon, 5 Jun 2006 16:55:31 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id DD0FCE54F2; Mon, 5 Jun 2006 14:51:53 -0600 (MDT) To: Kyle Galloway Cc: mauve-patches@sourceware.org, Keith Seitz Subject: Re: JDWP filter test cases References: <448462CD.5060405@redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Mon, 05 Jun 2006 20:56:00 -0000 In-Reply-To: <448462CD.5060405@redhat.com> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact mauve-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: mauve-patches-owner@sourceware.org X-SW-Source: 2006/txt/msg00367.txt.bz2 >>>>> "Kyle" == Kyle Galloway writes: Kyle> I have coded up some test cases for two of the JDWP filters(more to Kyle> come). I would appreciate it if someone would review and commit. So, these are unit tests for parts of the classpath jdwp implementation? You do need to add "Tags" comments to the new files. I think it is fine to do this, even a good thing :-). However I'd like Keith to weigh in on his preferred testing approach. Tom