public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] Fix off_t typedef on Cygwin64
@ 2016-08-30 15:36 Yaakov Selkowitz
0 siblings, 0 replies; only message in thread
From: Yaakov Selkowitz @ 2016-08-30 15:36 UTC (permalink / raw)
To: newlib-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=3d3ab829689f2563cfbfb65ce440cff8299a4ae9
commit 3d3ab829689f2563cfbfb65ce440cff8299a4ae9
Author: Yaakov Selkowitz <yselkowi@redhat.com>
Date: Mon Aug 29 15:30:59 2016 -0500
Fix off_t typedef on Cygwin64
While both long and long long are 64-bits on x86_64, they are distinct types,
and long was used prior to commit 477463a2011ba81907a753df9ce7a71b6563db54.
Changing this breaks the linking of previously compiled C++ functions with
off_t arguments on 64-bit Cygwin with newly compiled code, as the mangling of
long (l) and long long (x) differ.
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
Diff:
---
newlib/libc/include/sys/_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/newlib/libc/include/sys/_types.h b/newlib/libc/include/sys/_types.h
index 4bf2bc4..98b93ce 100644
--- a/newlib/libc/include/sys/_types.h
+++ b/newlib/libc/include/sys/_types.h
@@ -94,7 +94,7 @@ typedef __uint32_t __mode_t;
__extension__ typedef long long _off64_t;
#endif
-#ifdef __CYGWIN__
+#if defined(__CYGWIN__) && !defined(__LP64__)
typedef _off64_t __off_t;
#else
typedef _off_t __off_t;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-30 15:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-30 15:36 [newlib-cygwin] Fix off_t typedef on Cygwin64 Yaakov Selkowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).