public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] sys/cdefs.h: Define __hidden as empty on Cygwin
Date: Tue, 08 Nov 2016 15:16:00 -0000	[thread overview]
Message-ID: <20161108151635.97802.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=9ba4744620f277188955f90055237d9e89b8e6f9

commit 9ba4744620f277188955f90055237d9e89b8e6f9
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Tue Nov 8 16:14:43 2016 +0100

    sys/cdefs.h: Define __hidden as empty on Cygwin
    
    Non-default visibility attributes are unsupported on PE/COFF, so don't
    use in __hidden definition for Cygwin.  Add comment.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/include/sys/cdefs.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/cdefs.h
index 2a55a92..f569fc4 100644
--- a/newlib/libc/include/sys/cdefs.h
+++ b/newlib/libc/include/sys/cdefs.h
@@ -466,8 +466,13 @@
 #if __GNUC_PREREQ__(4, 0)
 #define	__sentinel	__attribute__((__sentinel__))
 #define	__exported	__attribute__((__visibility__("default")))
+/* Only default visibility is supported on PE/COFF targets. */
+#ifndef __CYGWIN__
 #define	__hidden	__attribute__((__visibility__("hidden")))
 #else
+#define	__hidden
+#endif
+#else
 #define	__sentinel
 #define	__exported
 #define	__hidden


                 reply	other threads:[~2016-11-08 15:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161108151635.97802.qmail@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).