public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] newlib: fvprintf: fix get_arg for !_MB_CAPABLE
Date: Tue, 09 Jan 2018 08:52:00 -0000	[thread overview]
Message-ID: <20180109085234.19644.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=1d01586b62dcf80236021cc514c487a1da160de6

commit 1d01586b62dcf80236021cc514c487a1da160de6
Author: Ivan Grokhotkov <ivan@espressif.com>
Date:   Tue Jan 9 14:07:25 2018 +0800

    newlib: fvprintf: fix get_arg for !_MB_CAPABLE
    
    Code path for _MB_CAPABLE scans for the '%' character and advances
    'fmt' pointer past '%'. Code path for !_MB_CAPABLE leaved fmt pointing
    to '%', which caused the state machine to go from START to DONE state
    immediately.

Diff:
---
 newlib/libc/stdio/vfprintf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/newlib/libc/stdio/vfprintf.c b/newlib/libc/stdio/vfprintf.c
index 50a3478..211cb17 100644
--- a/newlib/libc/stdio/vfprintf.c
+++ b/newlib/libc/stdio/vfprintf.c
@@ -2098,6 +2098,8 @@ _DEFUN(get_arg, (data, n, fmt, ap, numargs_p, args, arg_type, last_fmt),
 
       if (*fmt == '\0')
 	break;
+
+      fmt++;
 # endif /* ! _MB_CAPABLE */
       state = START;
       flags = 0;


                 reply	other threads:[~2018-01-09  8:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109085234.19644.qmail@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).