public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] ctype: align size of category bit fields to small targets needs
Date: Wed, 14 Mar 2018 10:54:00 -0000	[thread overview]
Message-ID: <20180314105401.80142.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=134f93f313db95c394b925716717031a05b2a6d3

commit 134f93f313db95c394b925716717031a05b2a6d3
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Wed Mar 14 10:36:34 2018 +0100

    ctype: align size of category bit fields to small targets needs
    
    E.g. arm ABI requires -fshort-enums for bare-metal toolchains.
    Given there are only 29 category enums, the compiler chooses an
    8 bit enum type, so a size of 11 bits for the bitfield leads to
    a compile time error:
    
      error: width of 'cat' exceeds its type
        enum category cat: 11;
                      ^~~
    
    Fix this by aligning the size of the category members to byte
    borders.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/ctype/categories.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/ctype/categories.c b/newlib/libc/ctype/categories.c
index db285d7..c237324 100644
--- a/newlib/libc/ctype/categories.c
+++ b/newlib/libc/ctype/categories.c
@@ -2,8 +2,8 @@
 #include "categories.h"
 
 struct _category {
-  enum category cat: 11;
-  unsigned int first: 21;
+  enum category cat: 8;
+  unsigned int first: 24;
   unsigned short delta;
 } __attribute__((packed));


             reply	other threads:[~2018-03-14 10:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 10:54 Corinna Vinschen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-14  9:42 Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314105401.80142.qmail@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).