From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92660 invoked by alias); 11 Jul 2018 15:17:10 -0000 Mailing-List: contact newlib-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-cvs-owner@sourceware.org Received: (qmail 92588 invoked by uid 9078); 11 Jul 2018 15:17:09 -0000 Date: Wed, 11 Jul 2018 15:17:00 -0000 Message-ID: <20180711151709.92586.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: newlib-cvs@sourceware.org Subject: [newlib-cygwin] Remove float compare option from sincosf X-Act-Checkin: newlib-cygwin X-Git-Author: Szabolcs Nagy X-Git-Refname: refs/heads/master X-Git-Oldrev: 358f3c61d651b06626126423140b825b6a1ea3d8 X-Git-Newrev: 81dc535bb9e0196203e706caa533713306b4fc2c X-SW-Source: 2018-q3/txt/msg00010.txt.bz2 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=81dc535bb9e0196203e706caa533713306b4fc2c commit 81dc535bb9e0196203e706caa533713306b4fc2c Author: Szabolcs Nagy Date: Tue Jul 10 17:14:32 2018 +0100 Remove float compare option from sincosf PREFER_FLOAT_COMPARISON setting was not correct as it could raise spurious exceptions. Fixing it is easy: just use ISLESS(x, y) instead of abstop12(x) < abstop12(y) with appropriate non-signaling definition for ISLESS. However it seems this setting is not very useful (there is only minor performance difference on various architectures), so remove this option for now. Diff: --- newlib/libm/common/sincosf.h | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/newlib/libm/common/sincosf.h b/newlib/libm/common/sincosf.h index 27f24ff..3cac8e8 100644 --- a/newlib/libm/common/sincosf.h +++ b/newlib/libm/common/sincosf.h @@ -43,21 +43,12 @@ extern const sincos_t __sincosf_table[2] HIDDEN; extern const uint32_t __inv_pio4[] HIDDEN; -/* abstop12 assumes floating point reinterpret is fast by default. - If floating point comparisons are faster, define PREFER_FLOAT_COMPARISON. */ -#if PREFER_FLOAT_COMPARISON -static inline float -abstop12 (float x) -{ - return fabsf (x); -} -#else +/* Top 12 bits of the float representation with the sign bit cleared. */ static inline uint32_t abstop12 (float x) { return (asuint (x) >> 20) & 0x7ff; } -#endif /* Compute the sine and cosine of inputs X and X2 (X squared), using the polynomial P and store the results in SINP and COSP. N is the quadrant,