public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Fix comparison between two character arrays
Date: Mon, 30 Jul 2018 07:37:00 -0000	[thread overview]
Message-ID: <20180730073729.55535.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=613a7f90361533fd5310ee836635a1e0864dfa71

commit 613a7f90361533fd5310ee836635a1e0864dfa71
Author: Jordi Sanfeliu <jordi@fibranet.cat>
Date:   Fri Jul 27 11:02:55 2018 +0200

    Fix comparison between two character arrays
    
    Hello,
    
    The member 'id' in the 'utmp' struct is not a numeric but a character array,
    hence the strncmp() function is needed to compare two members.

Diff:
---
 newlib/libc/unix/getut.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/unix/getut.c b/newlib/libc/unix/getut.c
index 89ed739..71a8c8f 100644
--- a/newlib/libc/unix/getut.c
+++ b/newlib/libc/unix/getut.c
@@ -63,7 +63,7 @@ getutid (struct utmp *id)
 	case LOGIN_PROCESS:
 	case USER_PROCESS:
 	case DEAD_PROCESS:
-	  if (id->ut_id == utmp_data.ut_id)
+	  if (!strncmp (id->ut_id, utmp_data.ut_id, sizeof (utmp_data.ut_id)))
 	    return &utmp_data;
 	  break;
 	default:


                 reply	other threads:[~2018-07-30  7:37 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730073729.55535.qmail@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).