public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Sebastian Huber <sh@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Implement a limit on on the number of IPv6 reassembly
Date: Fri, 24 Aug 2018 13:11:00 -0000	[thread overview]
Message-ID: <20180824131156.94619.qmail@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=823b09647103311555076967369cbc4db70c007a

commit 823b09647103311555076967369cbc4db70c007a
Author: jtl <jtl@FreeBSD.org>
Date:   Tue Aug 14 17:27:41 2018 +0000

    Implement a limit on on the number of IPv6 reassembly
    
    queues per bucket.
    
    There is a hashing algorithm which should distribute IPv6 reassembly
    queues across the available buckets in a relatively even way. However,
    if there is a flaw in the hashing algorithm which allows a large number
    of IPv6 fragment reassembly queues to end up in a single bucket, a per-
    bucket limit could help mitigate the performance impact of this flaw.
    
    Implement such a limit, with a default of twice the maximum number of
    reassembly queues divided by the number of buckets. Recalculate the
    limit any time the maximum number of reassembly queues changes.
    However, allow the user to override the value using a sysctl
    (net.inet6.ip6.maxfragbucketsize).
    
    Reviewed by:	jhb
    Security:	FreeBSD-SA-18:10.ip
    Security:	CVE-2018-6923

Diff:
---
 newlib/libc/sys/rtems/include/netinet6/in6.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/newlib/libc/sys/rtems/include/netinet6/in6.h b/newlib/libc/sys/rtems/include/netinet6/in6.h
index 235c990..00783e5 100644
--- a/newlib/libc/sys/rtems/include/netinet6/in6.h
+++ b/newlib/libc/sys/rtems/include/netinet6/in6.h
@@ -643,7 +643,8 @@ struct ip6_mtuinfo {
 #define	IPV6CTL_INTRDQMAXLEN	52	/* max length of direct IPv6 netisr
 					 * queue */
 #define	IPV6CTL_MAXFRAGSPERPACKET	53 /* Max fragments per packet */
-#define	IPV6CTL_MAXID		54
+#define	IPV6CTL_MAXFRAGBUCKETSIZE	54 /* Max reassembly queues per bucket */
+#define	IPV6CTL_MAXID		55
 #endif /* __BSD_VISIBLE */
 
 /*


                 reply	other threads:[~2018-08-24 13:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180824131156.94619.qmail@sourceware.org \
    --to=sh@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).