From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72526 invoked by alias); 21 Jan 2020 09:28:50 -0000 Mailing-List: contact newlib-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-cvs-owner@sourceware.org Received: (qmail 72507 invoked by uid 9078); 21 Jan 2020 09:28:50 -0000 Date: Tue, 21 Jan 2020 09:28:00 -0000 Message-ID: <20200121092850.72506.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: newlib-cvs@sourceware.org Subject: [newlib-cygwin] riscv: Add 'break' statements to fpsetround switch X-Act-Checkin: newlib-cygwin X-Git-Author: Keith Packard X-Git-Refname: refs/heads/master X-Git-Oldrev: 954504ea1424069c7c8d34fe771a505df8b8e3e1 X-Git-Newrev: 8e74c7119fb7f95662bb4986570a98496f259400 X-SW-Source: 2020-q1/txt/msg00005.txt https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=8e74c7119fb7f95662bb4986570a98496f259400 commit 8e74c7119fb7f95662bb4986570a98496f259400 Author: Keith Packard Date: Mon Jan 20 22:46:35 2020 -0800 riscv: Add 'break' statements to fpsetround switch This makes the fpsetround function actually do something rather than just return -1 due to the default 'fall-through' behavior of the switch statement. Signed-off-by: Keith Packard Diff: --- newlib/libc/machine/riscv/ieeefp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/newlib/libc/machine/riscv/ieeefp.c b/newlib/libc/machine/riscv/ieeefp.c index 68ace0b..c458322 100644 --- a/newlib/libc/machine/riscv/ieeefp.c +++ b/newlib/libc/machine/riscv/ieeefp.c @@ -84,10 +84,10 @@ fpsetround(fp_rnd rnd_dir) unsigned new_rm; switch (rnd_dir) { - case FP_RN: new_rm = 0; - case FP_RZ: new_rm = 1; - case FP_RM: new_rm = 2; - case FP_RP: new_rm = 3; + case FP_RN: new_rm = 0; break; + case FP_RZ: new_rm = 1; break; + case FP_RM: new_rm = 2; break; + case FP_RP: new_rm = 3; break; default: return -1; } fssr (new_rm << 5 | fsr & 0x1f);