From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92034 invoked by alias); 29 Jan 2020 17:59:43 -0000 Mailing-List: contact newlib-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-cvs-owner@sourceware.org Received: (qmail 91991 invoked by uid 9078); 29 Jan 2020 17:59:43 -0000 Date: Wed, 29 Jan 2020 17:59:00 -0000 Message-ID: <20200129175943.91989.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: newlib-cvs@sourceware.org Subject: [newlib-cygwin] Revert "newlib: fix fseek optimization with SEEK_CUR" X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/master X-Git-Oldrev: f36262d56ac78f04de147746ce4a85c6155e4a23 X-Git-Newrev: 2607f00423ead393f24b81b9fe5a39a37e036af8 X-SW-Source: 2020-q1/txt/msg00011.txt https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=2607f00423ead393f24b81b9fe5a39a37e036af8 commit 2607f00423ead393f24b81b9fe5a39a37e036af8 Author: Corinna Vinschen Date: Wed Jan 29 18:47:33 2020 +0100 Revert "newlib: fix fseek optimization with SEEK_CUR" This reverts commit 59362c80e3a02c011fd0ef3d7f07a20098d2a9d5. This breaks gnulib's autoconf test for POSIX compatibility of fflush/fseek. After fflush/fseek, ftello and lseek are out of sync, with lseek having the wrong offset. This breaks backward compatibility with Cygwin applications. Signed-off-by: Corinna Vinschen Diff: --- newlib/libc/stdio/fseeko.c | 31 +++++++++++++++++++++++++------ newlib/libc/stdio64/fseeko64.c | 31 +++++++++++++++++++++++++------ 2 files changed, 50 insertions(+), 12 deletions(-) diff --git a/newlib/libc/stdio/fseeko.c b/newlib/libc/stdio/fseeko.c index bbf1af4..3e0f9e9 100644 --- a/newlib/libc/stdio/fseeko.c +++ b/newlib/libc/stdio/fseeko.c @@ -141,12 +141,31 @@ _fseeko_r (struct _reent *ptr, switch (whence) { case SEEK_CUR: - curoff = _ftello_r(ptr, fp); - if (curoff == -1L) - { - _newlib_flockfile_exit (fp); - return EOF; - } + /* + * In order to seek relative to the current stream offset, + * we have to first find the current stream offset a la + * ftell (see ftell for details). + */ + _fflush_r (ptr, fp); /* may adjust seek offset on append stream */ + if (fp->_flags & __SOFF) + curoff = fp->_offset; + else + { + curoff = seekfn (ptr, fp->_cookie, (_fpos_t) 0, SEEK_CUR); + if (curoff == -1L) + { + _newlib_flockfile_exit (fp); + return EOF; + } + } + if (fp->_flags & __SRD) + { + curoff -= fp->_r; + if (HASUB (fp)) + curoff -= fp->_ur; + } + else if (fp->_flags & __SWR && fp->_p != NULL) + curoff += fp->_p - fp->_bf._base; offset += curoff; whence = SEEK_SET; diff --git a/newlib/libc/stdio64/fseeko64.c b/newlib/libc/stdio64/fseeko64.c index f380055..0672086 100644 --- a/newlib/libc/stdio64/fseeko64.c +++ b/newlib/libc/stdio64/fseeko64.c @@ -142,12 +142,31 @@ _fseeko64_r (struct _reent *ptr, switch (whence) { case SEEK_CUR: - curoff = _ftello64_r(ptr, fp); - if (curoff == -1L) - { - _newlib_flockfile_exit (fp); - return EOF; - } + /* + * In order to seek relative to the current stream offset, + * we have to first find the current stream offset a la + * ftell (see ftell for details). + */ + _fflush_r (ptr, fp); /* may adjust seek offset on append stream */ + if (fp->_flags & __SOFF) + curoff = fp->_offset; + else + { + curoff = seekfn (ptr, fp->_cookie, (_fpos64_t) 0, SEEK_CUR); + if (curoff == -1L) + { + _newlib_flockfile_exit(fp); + return EOF; + } + } + if (fp->_flags & __SRD) + { + curoff -= fp->_r; + if (HASUB (fp)) + curoff -= fp->_ur; + } + else if (fp->_flags & __SWR && fp->_p != NULL) + curoff += fp->_p - fp->_bf._base; offset += curoff; whence = SEEK_SET;