From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21832 invoked by alias); 14 Feb 2020 09:15:58 -0000 Mailing-List: contact newlib-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: newlib-cvs-owner@sourceware.org Received: (qmail 21608 invoked by uid 9078); 14 Feb 2020 09:15:42 -0000 Date: Fri, 14 Feb 2020 09:15:00 -0000 Message-ID: <20200214091542.21607.qmail@sourceware.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: newlib-cvs@sourceware.org Subject: [newlib-cygwin] pow: fix pow(-1.0, NaN) X-Act-Checkin: newlib-cygwin X-Git-Author: Nicolas Brunie X-Git-Refname: refs/heads/master X-Git-Oldrev: 8cb20fa5d3d3b8ee4d61360390e5192c1eba0a1c X-Git-Newrev: bb25dd1b0f39f343b764fd0db861cb9a30441407 X-SW-Source: 2020-q1/txt/msg00018.txt https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=bb25dd1b0f39f343b764fd0db861cb9a30441407 commit bb25dd1b0f39f343b764fd0db861cb9a30441407 Author: Nicolas Brunie Date: Fri Feb 14 10:12:25 2020 +0100 pow: fix pow(-1.0, NaN) I think I may have encountered a bug in the implementation of pow: pow(-1.0, NaN) returns 1.0 when it should return NaN. Because ix is used to check input vs 1.0 rather than hx, -1.0 is mistaken for 1.0 Diff: --- newlib/libm/math/e_pow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/newlib/libm/math/e_pow.c b/newlib/libm/math/e_pow.c index 6d2a501..5fd28e6 100644 --- a/newlib/libm/math/e_pow.c +++ b/newlib/libm/math/e_pow.c @@ -122,7 +122,7 @@ ivln2_l = 1.92596299112661746887e-08; /* 0x3E54AE0B, 0xF85DDF44 =1/ln2 tail*/ /* x|y==NaN return NaN unless x==1 then return 1 */ if(ix > 0x7ff00000 || ((ix==0x7ff00000)&&(lx!=0)) || iy > 0x7ff00000 || ((iy==0x7ff00000)&&(ly!=0))) { - if(((ix-0x3ff00000)|lx)==0) return one; + if(((hx-0x3ff00000)|lx)==0) return one; else return nan(""); }