public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Fix modf/f for NaN input
Date: Thu, 19 Mar 2020 15:34:51 +0000 (GMT)	[thread overview]
Message-ID: <20200319153451.C6378387102D@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=4ad9ba42fc3dd116bad8b9cb89d434256d3431fb

commit 4ad9ba42fc3dd116bad8b9cb89d434256d3431fb
Author: Fabian Schriever <fabian.schriever@gtd-gmbh.de>
Date:   Wed Mar 18 14:18:20 2020 +0100

    Fix modf/f for NaN input
    
    For NaN input the modf/f procedures should return NaN instead of zero
    with the sign of the input.

Diff:
---
 newlib/libm/common/s_modf.c  | 1 +
 newlib/libm/common/sf_modf.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/newlib/libm/common/s_modf.c b/newlib/libm/common/s_modf.c
index 8551a99e4..c948b8525 100644
--- a/newlib/libm/common/s_modf.c
+++ b/newlib/libm/common/s_modf.c
@@ -100,6 +100,7 @@ static double one = 1.0;
 	} else if (j0>51) {		/* no fraction part */
 	    __uint32_t high;
 	    *iptr = x*one;
+	    if (__fpclassifyd(x) == FP_NAN) return x+x; /* x is NaN, return NaN */
 	    GET_HIGH_WORD(high,x);
 	    INSERT_WORDS(x,high&0x80000000,0);	/* return +-0 */
 	    return x;
diff --git a/newlib/libm/common/sf_modf.c b/newlib/libm/common/sf_modf.c
index 6c64e3fa0..ae970762b 100644
--- a/newlib/libm/common/sf_modf.c
+++ b/newlib/libm/common/sf_modf.c
@@ -52,6 +52,7 @@ static float one = 1.0;
 	} else {			/* no fraction part */
 	    __uint32_t ix;
 	    *iptr = x*one;
+	    if (__fpclassifyf(x) == FP_NAN) return x+x; /* x is NaN, return NaN */
 	    GET_FLOAT_WORD(ix,x);
 	    SET_FLOAT_WORD(x,ix&0x80000000);	/* return +-0 */
 	    return x;


                 reply	other threads:[~2020-03-19 15:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200319153451.C6378387102D@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).