public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Fix hypotf missing mask in hi+lo decomposition
Date: Fri, 20 Mar 2020 09:13:07 +0000 (GMT)	[thread overview]
Message-ID: <20200320091307.F16AB3875DFD@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6b0c1e7cc8e4b0568f00c8444fff8da67688add3

commit 6b0c1e7cc8e4b0568f00c8444fff8da67688add3
Author: Fabian Schriever <fabian.schriever@gtd-gmbh.de>
Date:   Thu Mar 19 16:34:08 2020 +0100

    Fix hypotf missing mask in hi+lo decomposition
    
    Add the missing mask for the decomposition of hi+lo which caused some
    errors of 1-2 ULP.
    
    This change is taken over from FreeBSD:
    https://github.com/freebsd/freebsd/commit/95436ce20dab5a34ba46373410b96411b1734578
    
    Additionally I've removed some variable assignments which were never
    read before being overwritten again in the next 2 lines.

Diff:
---
 newlib/libm/math/ef_hypot.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libm/math/ef_hypot.c b/newlib/libm/math/ef_hypot.c
index 9368eb41c..a70c92b88 100644
--- a/newlib/libm/math/ef_hypot.c
+++ b/newlib/libm/math/ef_hypot.c
@@ -29,7 +29,7 @@
 	ha &= 0x7fffffffL;
 	GET_FLOAT_WORD(hb,y);
 	hb &= 0x7fffffffL;
-	if(hb > ha) {a=y;b=x;j=ha; ha=hb;hb=j;} else {a=x;b=y;}
+	if(hb > ha) { j = ha; ha = hb; hb = j; }
 	SET_FLOAT_WORD(a,ha);	/* a <- |a| */
 	SET_FLOAT_WORD(b,hb);	/* b <- |b| */
 	if((ha-hb)>0xf000000L) {return a+b;} /* x/y > 2**30 */
@@ -72,7 +72,7 @@
 	    a  = a+a;
 	    SET_FLOAT_WORD(y1,hb&0xfffff000L);
 	    y2 = b - y1;
-	    SET_FLOAT_WORD(t1,ha+0x00800000L);
+	    SET_FLOAT_WORD(t1,(ha+0x00800000L)&0xfffff000UL);
 	    t2 = a - t1;
 	    w  = __ieee754_sqrtf(t1*y1-(w*(-w)-(t1*y2+t2*b)));
 	}


                 reply	other threads:[~2020-03-20  9:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320091307.F16AB3875DFD@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).