public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] newlib/libm/math: Make pow/powf return qnan for snan arg
@ 2020-03-26 11:42 Corinna Vinschen
0 siblings, 0 replies; only message in thread
From: Corinna Vinschen @ 2020-03-26 11:42 UTC (permalink / raw)
To: newlib-cvs
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=6295d759133c399f1d4fcd224fa4f1bd2794288b
commit 6295d759133c399f1d4fcd224fa4f1bd2794288b
Author: Keith Packard via Newlib <newlib@sourceware.org>
Date: Wed Mar 25 17:18:21 2020 -0700
newlib/libm/math: Make pow/powf return qnan for snan arg
The IEEE spec for pow only has special case for x**0 and 1**y when x/y
are quiet NaN. For signaling NaN, the general case applies and these functions
should signal the invalid exception and return a quiet NaN.
Signed-off-by: Keith Packard <keithp@keithp.com>
Diff:
---
newlib/libm/math/e_pow.c | 13 +++++++++----
newlib/libm/math/ef_pow.c | 10 +++++++---
2 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/newlib/libm/math/e_pow.c b/newlib/libm/math/e_pow.c
index 5fd28e65f..4c450ec05 100644
--- a/newlib/libm/math/e_pow.c
+++ b/newlib/libm/math/e_pow.c
@@ -58,6 +58,8 @@
*/
#include "fdlibm.h"
+#include "math_config.h"
+
#if __OBSOLETE_MATH
#ifndef _DOUBLE_IS_32BITS
@@ -116,14 +118,17 @@ ivln2_l = 1.92596299112661746887e-08; /* 0x3E54AE0B, 0xF85DDF44 =1/ln2 tail*/
EXTRACT_WORDS(hy,ly,y);
ix = hx&0x7fffffff; iy = hy&0x7fffffff;
- /* y==zero: x**0 = 1 */
- if((iy|ly)==0) return one;
+ /* y==zero: x**0 = 1 unless x is snan */
+ if((iy|ly)==0) {
+ if (issignaling_inline(x)) return x + y;
+ return one;
+ }
/* x|y==NaN return NaN unless x==1 then return 1 */
if(ix > 0x7ff00000 || ((ix==0x7ff00000)&&(lx!=0)) ||
iy > 0x7ff00000 || ((iy==0x7ff00000)&&(ly!=0))) {
- if(((hx-0x3ff00000)|lx)==0) return one;
- else return nan("");
+ if(((hx-0x3ff00000)|lx)==0 && !issignaling_inline(y)) return one;
+ else return x + y;
}
/* determine if y is an odd int when x < 0
diff --git a/newlib/libm/math/ef_pow.c b/newlib/libm/math/ef_pow.c
index d9e85a95e..d4ea4c5e8 100644
--- a/newlib/libm/math/ef_pow.c
+++ b/newlib/libm/math/ef_pow.c
@@ -14,6 +14,7 @@
*/
#include "fdlibm.h"
+#include "math_config.h"
#if __OBSOLETE_MATH
#ifdef __v810__
@@ -74,13 +75,16 @@ ivln2_l = 7.0526075433e-06; /* 0x36eca570 =1/ln2 tail*/
ix = hx&0x7fffffff; iy = hy&0x7fffffff;
/* y==zero: x**0 = 1 */
- if(FLT_UWORD_IS_ZERO(iy)) return one;
+ if(FLT_UWORD_IS_ZERO(iy)) {
+ if (issignalingf_inline(x)) return x + y;
+ return one;
+ }
/* x|y==NaN return NaN unless x==1 then return 1 */
if(FLT_UWORD_IS_NAN(ix) ||
FLT_UWORD_IS_NAN(iy)) {
- if(hx==0x3f800000) return one;
- else return nanf("");
+ if(hx==0x3f800000 && !issignalingf_inline(y)) return one;
+ else return x + y;
}
/* determine if y is an odd int when x < 0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-03-26 11:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 11:42 [newlib-cygwin] newlib/libm/math: Make pow/powf return qnan for snan arg Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).