public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] MSP430: Fix message in sbrk.c printing binary character
Date: Thu,  3 Sep 2020 11:43:11 +0000 (GMT)	[thread overview]
Message-ID: <20200903114311.4790B3850402@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=d72ea86d41e1295839de8cd9564bb8b44a8d862a

commit d72ea86d41e1295839de8cd9564bb8b44a8d862a
Author: Jozef Lawrynowicz <jozef.l@mittosystems.com>
Date:   Wed Sep 2 16:16:55 2020 +0100

    MSP430: Fix message in sbrk.c printing binary character
    
    The call to write() in sbrk.c was using the wrong value for the length
    argument, causing the NUL terminating character of the string to be
    printed.

Diff:
---
 libgloss/msp430/sbrk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libgloss/msp430/sbrk.c b/libgloss/msp430/sbrk.c
index bbc3fb5ba..8e4339f6e 100644
--- a/libgloss/msp430/sbrk.c
+++ b/libgloss/msp430/sbrk.c
@@ -24,8 +24,8 @@ _sbrk (int adj)
 
   if (heap + adj > sp)
     {
-#define MESSAGE "Heap and stack collision\n"
-      write (1, MESSAGE, sizeof MESSAGE);
+      const char * const msg = "Heap and stack collision\n";
+      write (1, msg, sizeof (msg) - 1);
       abort ();
     }


                 reply	other threads:[~2020-09-03 11:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200903114311.4790B3850402@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).