public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] libc/include/inttypes.h: Remove parameter name
Date: Fri,  2 Oct 2020 21:00:59 +0000 (GMT)	[thread overview]
Message-ID: <20201002210059.90D2C393C848@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=615cf4bdce0de86e57bdc27e008a35dd713e483f

commit 615cf4bdce0de86e57bdc27e008a35dd713e483f
Author: Torbjörn SVENSSON <torbjorn.svensson@st.com>
Date:   Thu Oct 1 12:44:43 2020 +0200

    libc/include/inttypes.h: Remove parameter name
    
    As discussed in GCC bug 97088
    (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97088), parameters in
    prototypes of library functions should use reserved names, or no name
    at all.
    
    This patch removes the 'j' parameter name from
    extern intmax_t  imaxabs(intmax_t);
    
    to avoid possible clashes with user code in case someone uses
    before including Newlib's inttypes.h (or uses some other conflicting
    definition)
    
    Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>

Diff:
---
 newlib/libc/include/inttypes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/include/inttypes.h b/newlib/libc/include/inttypes.h
index 073215476..570ed0481 100644
--- a/newlib/libc/include/inttypes.h
+++ b/newlib/libc/include/inttypes.h
@@ -320,7 +320,7 @@ struct _reent;
 extern "C" {
 #endif
 
-extern intmax_t  imaxabs(intmax_t j);
+extern intmax_t  imaxabs(intmax_t);
 extern imaxdiv_t imaxdiv(intmax_t numer, intmax_t denomer);
 extern intmax_t  strtoimax(const char *__restrict, char **__restrict, int);
 extern intmax_t  _strtoimax_r(struct _reent *, const char *__restrict, char **__restrict, int);


                 reply	other threads:[~2020-10-02 21:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201002210059.90D2C393C848@sourceware.org \
    --to=jjohnstn@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).