public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] amd64: prevent KCSan false positives on LAPIC mapping
@ 2020-10-26 13:31 Sebastian Huber
  0 siblings, 0 replies; only message in thread
From: Sebastian Huber @ 2020-10-26 13:31 UTC (permalink / raw)
  To: newlib-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=303c61925d9256be02dcbda8f1e5e0d4adf8b3b9

commit 303c61925d9256be02dcbda8f1e5e0d4adf8b3b9
Author: jah <jah@FreeBSD.org>
Date:   Sat Sep 12 07:04:00 2020 +0000

    amd64: prevent KCSan false positives on LAPIC mapping
    
    For configurations without x2APIC support (guests, older hardware), the global
    LAPIC MMIO mapping will trigger false-positive KCSan reports as it will appear
    that multiple CPUs are concurrently reading and writing the same address.
    This isn't actually true, as the underlying physical access will be performed
    on the local CPU's APIC. Additionally, because LAPIC access can happen during
    event timer configuration, the resulting KCSan printf can produce a panic due
    to attempted recursion on event timer resources.
    
    Add a __nosanitizethread preprocessor define to prevent the compiler from
    inserting TSan hooks, and apply it to the x86 LAPIC accessors.
    
    PR:             249149
    Reported by:    gbe
    Reviewed by:    andrew, kib
    Tested by:      gbe
    Differential Revision:  https://reviews.freebsd.org/D26354

Diff:
---
 newlib/libc/include/sys/cdefs.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/newlib/libc/include/sys/cdefs.h b/newlib/libc/include/sys/cdefs.h
index 1be994ffd..da7290921 100644
--- a/newlib/libc/include/sys/cdefs.h
+++ b/newlib/libc/include/sys/cdefs.h
@@ -716,8 +716,10 @@
  */
 #if __has_attribute(no_sanitize) && defined(__clang__)
 #define __nosanitizeaddress	__attribute__((no_sanitize("address")))
+#define __nosanitizethread	__attribute__((no_sanitize("thread")))
 #else
 #define __nosanitizeaddress
+#define __nosanitizethread
 #endif
 
 /* Guard variables and structure members by lock. */


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-10-26 13:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 13:31 [newlib-cygwin] amd64: prevent KCSan false positives on LAPIC mapping Sebastian Huber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).