From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id D2270398EC1F; Wed, 28 Jul 2021 09:33:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2270398EC1F Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Corinna Vinschen To: newlib-cvs@sourceware.org Subject: [newlib-cygwin] Remove unneccesary parenthesis around declarator X-Act-Checkin: newlib-cygwin X-Git-Author: Maxim Blinov X-Git-Refname: refs/heads/master X-Git-Oldrev: 51a297bcbf05f332462a577563234062660e6384 X-Git-Newrev: 05425831290c9869bc7987b5df3ce84aa4f19a6c Message-Id: <20210728093304.D2270398EC1F@sourceware.org> Date: Wed, 28 Jul 2021 09:33:04 +0000 (GMT) X-BeenThere: newlib-cvs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Newlib GIT logs List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 09:33:04 -0000 https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=05425831290c9869bc7987b5df3ce84aa4f19a6c commit 05425831290c9869bc7987b5df3ce84aa4f19a6c Author: Maxim Blinov Date: Thu Jul 22 22:41:42 2021 +0100 Remove unneccesary parenthesis around declarator riscv64-unknown-elf-g++-11.1.0 regression suite reports the following failures for $ make check-gcc-c++ RUNTESTFLAGS='dg.exp=Wstringop-overflow-6.C' ``` FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++14 (test for excess errors) FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++17 (test for excess errors) FAIL: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++2a (test for excess errors) UNSUPPORTED: g++.dg/warn/Wstringop-overflow-6.C -std=gnu++98 ``` The "excess errors" being ``` output is In file included from /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/wchar.h:6, from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/cwchar:44, from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/bits/postypes.h:40, from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iosfwd:40, from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ios:38, from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/ostream:38, from /home/maxim/prj/riscv-upstream/build/gcc-stage2/riscv64-unknown-elf/libstdc++-v3/include/iostream:39, from /home/maxim/prj/riscv-upstream/gcc-11.1.0/gcc/testsuite/g++.dg/warn/Wstringop-overflow-6.C:6: /home/maxim/prj/riscv-upstream/install/riscv64-unknown-elf/include/sys/reent.h:685:11: warning: unnecessary parentheses in declaration of '_sig_func' [-Wparentheses] ``` Diff: --- newlib/libc/include/sys/reent.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h index 74b70e9c0..e4e36170e 100644 --- a/newlib/libc/include/sys/reent.h +++ b/newlib/libc/include/sys/reent.h @@ -682,7 +682,7 @@ struct _reent # endif /* signal info */ - void (**(_sig_func))(int); + void (**_sig_func)(int); /* These are here last so that __FILE can grow without changing the offsets of the above members (on the off chance that future binary compatibility