public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] sys/tree.h: Simplify loop condition
@ 2021-10-07 16:02 Sebastian Huber
  0 siblings, 0 replies; only message in thread
From: Sebastian Huber @ 2021-10-07 16:02 UTC (permalink / raw)
  To: newlib-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=098cf0f98dbb310c6a7ef94f0bdaf683f276767b

commit 098cf0f98dbb310c6a7ef94f0bdaf683f276767b
Author: Sebastian Huber <sebastian.huber@embedded-brains.de>
Date:   Tue Oct 5 15:31:22 2021 +0200

    sys/tree.h: Simplify loop condition
    
    We have
    
      #define RB_ISRED(elm, field) \
        ((elm) != NULL && RB_COLOR(elm, field) == RB_RED)
    
    So, the RB_ISRED() contains an implicit check for NULL.  In
    RB_GENERATE_REMOVE_COLOR() the "elm" pointer cannot be NULL in the while
    condition.  Use RB_COLOR(elm) == RB_BLACK instead.

Diff:
---
 newlib/libc/include/sys/tree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/include/sys/tree.h b/newlib/libc/include/sys/tree.h
index 2af77a499..15831c7dd 100644
--- a/newlib/libc/include/sys/tree.h
+++ b/newlib/libc/include/sys/tree.h
@@ -540,7 +540,7 @@ name##_RB_REMOVE_COLOR(struct name *head, struct type *parent)		\
 			elm = RB_ROOT(head);				\
 			break;						\
 		}							\
-	} while (!RB_ISRED(elm, field) && parent != NULL);		\
+	} while (RB_COLOR(elm, field) == RB_BLACK && parent != NULL);	\
 	RB_COLOR(elm, field) = RB_BLACK;				\
 }


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-07 16:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 16:02 [newlib-cygwin] sys/tree.h: Simplify loop condition Sebastian Huber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).