public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
* [newlib-cygwin] sys/tree.h: Simplify chain of conditions
@ 2021-10-07 16:02 Sebastian Huber
  0 siblings, 0 replies; only message in thread
From: Sebastian Huber @ 2021-10-07 16:02 UTC (permalink / raw)
  To: newlib-cvs

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=ee30f991c38851f1bfbbf72d19c5c6ee1b97f32a

commit ee30f991c38851f1bfbbf72d19c5c6ee1b97f32a
Author: Sebastian Huber <sebastian.huber@embedded-brains.de>
Date:   Tue Oct 5 15:39:10 2021 +0200

    sys/tree.h: Simplify chain of conditions
    
    In RB_GENERATE_REMOVE_COLOR() simplify a chain of conditions of the following
    pattern
    
    if (x) {
      ...
    } else if (!x) {
      ...
    }
    
    to
    
    if (x) {
      ...
    } else {
      ...
    }

Diff:
---
 newlib/libc/include/sys/tree.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/include/sys/tree.h b/newlib/libc/include/sys/tree.h
index 15831c7dd..180809e9b 100644
--- a/newlib/libc/include/sys/tree.h
+++ b/newlib/libc/include/sys/tree.h
@@ -528,7 +528,7 @@ name##_RB_REMOVE_COLOR(struct name *head, struct type *parent)		\
 				RB_ROTATE_LEFT(head, tmp, oright, field); \
 				RB_COLOR(oright, field) = RB_BLACK;	\
 				tmp = oright;				\
-			} else if (!RB_ISRED(RB_LEFT(tmp, field), field)) { \
+			} else {					\
 				RB_COLOR(tmp, field) = RB_RED;		\
 				elm = parent;				\
 				parent = RB_PARENT(elm, field);		\


^ permalink raw reply	[flat|nested] only message in thread
only message in thread, other threads:[~2021-10-07 16:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 16:02 [newlib-cygwin] sys/tree.h: Simplify chain of conditions Sebastian Huber

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).