public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Unconditionally declare strsignal
Date: Wed, 27 Oct 2021 18:06:34 +0000 (GMT)	[thread overview]
Message-ID: <20211027180634.203213858405@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=26894de91d296af502b53c243e71f88c06ea1a3d

commit 26894de91d296af502b53c243e71f88c06ea1a3d
Author: Christian Biesinger via Newlib <newlib@sourceware.org>
Date:   Wed Oct 27 12:41:22 2021 -0400

    Unconditionally declare strsignal
    
    Currently, newlib does not declare strsignal if DEFS_H is defined,
    ostensibly to work around a gdb bug. However, gdb itself compiles
    even with this ifndef removed, and this makes sim (another part of
    gdb) fail to compile.
    
    Since it is not clear exactly what issue this was working around,
    this patch just replaces that ifdef with the correct check,
    i.e. __POSIX_VISIBLE >= 200809.

Diff:
---
 newlib/libc/include/string.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libc/include/string.h b/newlib/libc/include/string.h
index 60e837bc0..32199c027 100644
--- a/newlib/libc/include/string.h
+++ b/newlib/libc/include/string.h
@@ -130,7 +130,7 @@ char	*strlwr (char *);
 char	*strupr (char *);
 #endif
 
-#ifndef DEFS_H	/* Kludge to work around problem compiling in gdb */
+#if __POSIX_VISIBLE >= 200809
 char	*strsignal (int __signo);
 #endif


                 reply	other threads:[~2021-10-27 18:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211027180634.203213858405@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).