public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Frysinger <vapier@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] newlib: ignore _FORTIFY_SOURCE when building newlib
Date: Sat, 13 Nov 2021 05:10:01 +0000 (GMT)	[thread overview]
Message-ID: <20211113051001.F1157385840B@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=df5de02e0ebc8627683bc50aeb68d0d2b0806f09

commit df5de02e0ebc8627683bc50aeb68d0d2b0806f09
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Mon Nov 8 21:42:12 2021 -0500

    newlib: ignore _FORTIFY_SOURCE when building newlib
    
    Some distros enable _FORTIFY_SOURCE by default which upsets building
    newlib which itself implements the logic for this define.  For example,
    building gets.c fails because the includes set up a gets() macro which
    expands in the definition.
    
    Since newlib isn't prepared to build itself with _FORTIFY_SOURCE, and
    it's not clear if it's even useful, ignore it when building the code.
    This also matches what glibc is doing.

Diff:
---
 newlib/libc/include/sys/features.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/newlib/libc/include/sys/features.h b/newlib/libc/include/sys/features.h
index 218807178..6b4999e83 100644
--- a/newlib/libc/include/sys/features.h
+++ b/newlib/libc/include/sys/features.h
@@ -320,7 +320,8 @@ extern "C" {
 #endif
 
 #if _FORTIFY_SOURCE > 0 && !defined(__cplusplus) && !defined(__lint__) && \
-   (__OPTIMIZE__ > 0 || defined(__clang__)) && __GNUC_PREREQ__(4, 1)
+   (__OPTIMIZE__ > 0 || defined(__clang__)) && __GNUC_PREREQ__(4, 1) && \
+   !defined(_COMPILING_NEWLIB)
 #  if _FORTIFY_SOURCE > 1
 #    define __SSP_FORTIFY_LEVEL 2
 #  else


                 reply	other threads:[~2021-11-13  5:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211113051001.F1157385840B@sourceware.org \
    --to=vapier@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).