public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Improve lgammaf range for very small cases
Date: Mon, 14 Feb 2022 13:44:22 +0000 (GMT)	[thread overview]
Message-ID: <20220214134422.B70AB3858412@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=ec69debcb977d6395f9e91ee20133de473484e20

commit ec69debcb977d6395f9e91ee20133de473484e20
Author: Andoni Arregi <andoni.arregui@gtd-gmbh.de>
Date:   Fri Feb 11 12:16:00 2022 +0100

    Improve lgammaf range for very small cases
    
    The original cut for small arguments at |x|<2**-70 (copied from the
    double version) produces that when computing nadj we get a subnormal
    number for t*x and thus, the division of pi/subnormal will be INF and
    the logarithm of it too, which is wrong as a result for lgammaf in this
    range.
    The proposed new limit seems to be safe and has been tested to
    produce accurate results.
    (Courtesy of Andreas Jung, ESA)

Diff:
---
 newlib/libm/math/erf_lgamma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/newlib/libm/math/erf_lgamma.c b/newlib/libm/math/erf_lgamma.c
index f88f63092..84d02159b 100644
--- a/newlib/libm/math/erf_lgamma.c
+++ b/newlib/libm/math/erf_lgamma.c
@@ -168,7 +168,7 @@ static float zero=  0.0000000000e+00;
 	        *signgamp = -1;
 	    return one/(x-x);
 	}
-	if(ix<0x1c800000) {	/* |x|<2**-70, return -log(|x|) */
+	if(ix<0x30800000) {	/* |x|<2**-30, return -log(|x|) */
 	    if(hx<0) {
 	        *signgamp = -1;
 	        return -__ieee754_logf(-x);


                 reply	other threads:[~2022-02-14 13:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220214134422.B70AB3858412@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).