public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Sebastian Huber <sh@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Use weak reference for _REENT_SMALL
Date: Thu, 19 May 2022 17:02:31 +0000 (GMT)	[thread overview]
Message-ID: <20220519170231.CAFF9396DC2C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=03e815a91b1a1f94ce0cfd6ff64f50ae40ed740c

commit 03e815a91b1a1f94ce0cfd6ff64f50ae40ed740c
Author: Sebastian Huber <sebastian.huber@embedded-brains.de>
Date:   Tue May 17 20:39:35 2022 +0200

    Use weak reference for _REENT_SMALL
    
    Avoid a strong reference to __sfp[] for _impure_data.  The __sfp[] is linked in
    if __sinit() is used for example.

Diff:
---
 newlib/libc/reent/impure.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/newlib/libc/reent/impure.c b/newlib/libc/reent/impure.c
index f10665fd0..643a511c6 100644
--- a/newlib/libc/reent/impure.c
+++ b/newlib/libc/reent/impure.c
@@ -6,10 +6,14 @@
    important to reduce image size for targets with very small amounts
    of memory.  */
 #ifdef _REENT_SMALL
+#ifdef _REENT_GLOBAL_STDIO_STREAMS
+extern __FILE __sf[3] _ATTRIBUTE ((weak));
+#else
 extern const struct __sFILE_fake __sf_fake_stdin _ATTRIBUTE ((weak));
 extern const struct __sFILE_fake __sf_fake_stdout _ATTRIBUTE ((weak));
 extern const struct __sFILE_fake __sf_fake_stderr _ATTRIBUTE ((weak));
 #endif
+#endif
 
 struct _reent __ATTRIBUTE_IMPURE_DATA__ _impure_data = _REENT_INIT (_impure_data);
 #ifdef __CYGWIN__


                 reply	other threads:[~2022-05-19 17:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519170231.CAFF9396DC2C@sourceware.org \
    --to=sh@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).