public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin/main] newlocale: set errno to ENOENT if __loadlocale fails
Date: Fri, 24 Mar 2023 11:51:56 +0000 (GMT)	[thread overview]
Message-ID: <20230324115156.E130C387088C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=606373e7d2e7009209ca536ab1c9c3393af61275

commit 606373e7d2e7009209ca536ab1c9c3393af61275
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Fri Mar 24 10:51:31 2023 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Fri Mar 24 12:44:52 2023 +0100

    newlocale: set errno to ENOENT if __loadlocale fails
    
    __loadlocale never sets errno, but newlocale is supposed to
    return ENOENT if the locale isn't valid.
    
    Fixes: aefd8b5b518b ("Implement newlocale, freelocale, duplocale, uselocale")
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 newlib/libc/locale/newlocale.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/newlib/libc/locale/newlocale.c b/newlib/libc/locale/newlocale.c
index 08f29dbcc0c1..278f78ed2462 100644
--- a/newlib/libc/locale/newlocale.c
+++ b/newlib/libc/locale/newlocale.c
@@ -171,7 +171,10 @@ _newlocale_r (struct _reent *p, int category_mask, const char *locale,
 	    continue;
 	  /* Otherwise load locale data. */
 	  else if (!__loadlocale (&tmp_locale, i, new_categories[i]))
-	    goto error;
+	    {
+	      p->_errno = ENOENT;
+	      goto error;
+	    }
 	}
     }
   /* Allocate new locale_t. */

                 reply	other threads:[~2023-03-24 11:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230324115156.E130C387088C@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).