public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Sebastian Huber <sh@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Fix _REENT_EMERGENCY() if TLS is enabled
Date: Wed, 26 Apr 2023 09:56:06 +0000 (GMT)	[thread overview]
Message-ID: <20230426095606.E5C7E3858CDA@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=e301a74a6f111df4553b50b813a589589d1708b1

commit e301a74a6f111df4553b50b813a589589d1708b1
Author: Sebastian Huber <sebastian.huber@embedded-brains.de>
Date:   Wed Apr 26 08:23:04 2023 +0200

    Fix _REENT_EMERGENCY() if TLS is enabled
    
    If the thread-local storage (TLS) support was enabled, the _REENT_EMERGENCY()
    object had the wrong size.  It must be a buffer of length _REENT_EMERGENCY_SIZE
    and not just a single character.

Diff:
---
 newlib/libc/include/sys/reent.h | 2 +-
 newlib/libc/stdio/tmpnam.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/newlib/libc/include/sys/reent.h b/newlib/libc/include/sys/reent.h
index 6d8b005b2..c71f75dbc 100644
--- a/newlib/libc/include/sys/reent.h
+++ b/newlib/libc/include/sys/reent.h
@@ -812,7 +812,7 @@ extern _Thread_local int _tls_cvtlen;
 #define _REENT_CVTLEN(_ptr) (_tls_cvtlen)
 extern _Thread_local void (*_tls_cleanup)(struct _reent *);
 #define _REENT_CLEANUP(_ptr) (_tls_cleanup)
-extern _Thread_local char _tls_emergency;
+extern _Thread_local char _tls_emergency[_REENT_EMERGENCY_SIZE];
 #define _REENT_EMERGENCY(_ptr) (_tls_emergency)
 extern _Thread_local int _tls_errno;
 #define _REENT_ERRNO(_ptr) (_tls_errno)
diff --git a/newlib/libc/stdio/tmpnam.c b/newlib/libc/stdio/tmpnam.c
index 51dfd1cea..dc04cf3f6 100644
--- a/newlib/libc/stdio/tmpnam.c
+++ b/newlib/libc/stdio/tmpnam.c
@@ -84,7 +84,7 @@ The global pointer <<environ>> is also required.
 
 #ifdef _REENT_THREAD_LOCAL
 _Thread_local int _tls_inc;
-_Thread_local char _tls_emergency;
+_Thread_local char _tls_emergency[_REENT_EMERGENCY_SIZE];
 #endif
 
 /* Try to open the file specified, if it can't be opened then try

                 reply	other threads:[~2023-04-26  9:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230426095606.E5C7E3858CDA@sourceware.org \
    --to=sh@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).