From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jturney@sourceware.org>
Received: by sourceware.org (Postfix, from userid 2201)
	id EDF40385843E; Fri, 14 Jul 2023 15:28:43 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EDF40385843E
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org;
	s=default; t=1689348523;
	bh=FZu572qxoRhI9nYwaaO98OgI5oLLatmpTIALxuVw9FM=;
	h=From:To:Subject:Date:From;
	b=dCCuuAizj4bLPnoQtbPxRurVOKUmTqVoUMRRXixU18D/kdHgtBTXIu7cM8zLDaEXD
	 3BYHR3DrCQnI0XzdXhm9bL1IZpfTA1IU/sgYbkSLJQNKrOVib9/bUhto09XkvFkIs6
	 C34XXY8uQmNPnYkCFus+9ng53eDQCgeVt78IF1jw=
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Jon Turney <jturney@sourceware.org>
To: cygwin-cvs@sourceware.org, newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Cygwin: testsuite: Drop Adminstrator privileges while running tests
X-Act-Checkin: newlib-cygwin
X-Git-Author: Jon Turney <jon.turney@dronecode.org.uk>
X-Git-Refname: refs/heads/master
X-Git-Oldrev: 10e50f9617a851469c007cfe98666c8bc22f960b
X-Git-Newrev: fee0c04e30e31d9034276ecb70cc8dd82e33e761
Message-Id: <20230714152843.EDF40385843E@sourceware.org>
Date: Fri, 14 Jul 2023 15:28:43 +0000 (GMT)
List-Id: <newlib-cvs.sourceware.org>

https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3Dfee0c04e30e=
31d9034276ecb70cc8dd82e33e761

commit fee0c04e30e31d9034276ecb70cc8dd82e33e761
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Tue Jul 11 15:40:09 2023 +0100

    Cygwin: testsuite: Drop Adminstrator privileges while running tests
   =20
    Test access05 and symlink03 expect operations to fail which succeed when
    we have Adminstrator privileges.
   =20
    There's perhaps a bit of incoherency here: some XFAILed tests expect to
    run as root (so maybe we need the ability to selectively cygdrop?).
   =20
    Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>

Diff:
---
 .github/workflows/cygwin.yml           | 1 +
 winsup/doc/faq-programming.xml         | 5 +++--
 winsup/testsuite/winsup.api/winsup.exp | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/cygwin.yml b/.github/workflows/cygwin.yml
index 248a3e4cd..39553d37a 100644
--- a/.github/workflows/cygwin.yml
+++ b/.github/workflows/cygwin.yml
@@ -73,6 +73,7 @@ jobs:
           automake,
           busybox,
           cocom,
+          cygutils-extra,
           dblatex,
           dejagnu,
           docbook-xml45,
diff --git a/winsup/doc/faq-programming.xml b/winsup/doc/faq-programming.xml
index 15ae6eac4..2c684bb2b 100644
--- a/winsup/doc/faq-programming.xml
+++ b/winsup/doc/faq-programming.xml
@@ -697,8 +697,9 @@ Building these programs can be disabled with the <liter=
al>--without-cross-bootst
 option to <literal>configure</literal>.
 </para>
=20
-<!-- If you want to run the tests, <literal>dejagnu</literal> and
-     <literal>busybox</literal> are also required. -->
+<!-- If you want to run the tests, <literal>dejagnu</literal>,
+     <literal>busybox</literal> and <literal>cygutils-extra<literal> are a=
lso
+     required. -->
=20
 <para>
 Building the documentation also requires the <literal>dblatex</literal>,
diff --git a/winsup/testsuite/winsup.api/winsup.exp b/winsup/testsuite/wins=
up.api/winsup.exp
index fb3e3816c..111509511 100644
--- a/winsup/testsuite/winsup.api/winsup.exp
+++ b/winsup/testsuite/winsup.api/winsup.exp
@@ -64,7 +64,7 @@ foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c =
$srcdir/$subdir/*/*.{cc
 	    }
 	    file mkdir $tmpdir/$tmpfile
 	    set env(PATH) "$runtime_root:$env(PATH)"
-	    ws_spawn "$cygrun $exec $testdll_tmpdir/$tmpfile > $redirect_output"
+	    ws_spawn "cygdrop $cygrun $exec $testdll_tmpdir/$tmpfile > $redirect_=
output"
 	    file delete -force $tmpdir/$tmpfile
 	    set env(PATH) "$orig_path"
 	    if { $rv } {