public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Corinna Vinschen <corinna@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin/main] Reclaim _REENT_MP_P5S in _reclaim_reent
Date: Mon, 20 Nov 2023 10:23:10 +0000 (GMT)	[thread overview]
Message-ID: <20231120102310.DA0573858D35@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=37e67d15950a52b096601e98081abc2b17bd3a2b

commit 37e67d15950a52b096601e98081abc2b17bd3a2b
Author:     Chris Johns <chrisj@rtems.org>
AuthorDate: Mon Nov 20 12:04:58 2023 +1100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Mon Nov 20 10:49:39 2023 +0100

    Reclaim _REENT_MP_P5S in _reclaim_reent
    
    The _REENT_MP_P5S blocks are allocated using Balloc via i2b and linked in the
    pow5mult call. As a result these blocks are not on the freelist managed by the
    Bfree call. This change fixes a memory leak in threads that clean up using
    _reclaim_reent.
    
    RTEMS: Closes #4967

Diff:
---
 newlib/libc/reent/reent.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/newlib/libc/reent/reent.c b/newlib/libc/reent/reent.c
index db80ca06e369..74503fa59291 100644
--- a/newlib/libc/reent/reent.c
+++ b/newlib/libc/reent/reent.c
@@ -59,6 +59,17 @@ _reclaim_reent (struct _reent *ptr)
 	}
       if (_REENT_MP_RESULT(ptr))
 	_free_r (ptr, _REENT_MP_RESULT(ptr));
+      if (_REENT_MP_P5S(ptr))
+        {
+          struct _Bigint *thisone, *nextone;
+          nextone = _REENT_MP_P5S(ptr);
+          while (nextone)
+           {
+             thisone = nextone;
+             nextone = nextone->_next;
+             _free_r (ptr, thisone);
+           }
+        }
 #ifdef _REENT_SMALL
       }
 #endif

                 reply	other threads:[~2023-11-20 10:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231120102310.DA0573858D35@sourceware.org \
    --to=corinna@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).