From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2155) id 2366B3858C30; Mon, 20 Nov 2023 20:02:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2366B3858C30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1700510536; bh=0Q8SliWdOmC0l0+2u00Pv05h7GB++HDX/46hMLpWECs=; h=From:To:Subject:Date:From; b=AMwVaQRxZNhx0uaGKCVqlbfkG237P+iYdnJG0UsnZ8a5c4diqcVFs8OxjywskN1GE cyanb95VxS+YrnUgX7CRqB/BZw+HkuY++L8ILUTLUfkvfWfKkzt0lyMmsCZlTqpsMp 2R4bQ6gF2vQE5+4PsBiCIxt6e0wYPdfe2lr1ToKc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Corinna Vinschen To: newlib-cvs@sourceware.org Subject: [newlib-cygwin/main] stdio: drop unnecessary calls to ORIENT X-Act-Checkin: newlib-cygwin X-Git-Author: Corinna Vinschen X-Git-Refname: refs/heads/main X-Git-Oldrev: c190063f9658153988d735a333a7a3c7aeadc001 X-Git-Newrev: 61e52c4d60c57f520cd19de310260395add5ce97 Message-Id: <20231120200216.2366B3858C30@sourceware.org> Date: Mon, 20 Nov 2023 20:02:16 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D61e52c4d60c= 57f520cd19de310260395add5ce97 commit 61e52c4d60c57f520cd19de310260395add5ce97 Author: Corinna Vinschen AuthorDate: Mon Nov 20 20:49:53 2023 +0100 Commit: Corinna Vinschen CommitDate: Mon Nov 20 20:59:47 2023 +0100 stdio: drop unnecessary calls to ORIENT =20 Now that the low-level functions set and test stream orientation, a few calls in API functions are redundant. =20 Signed-off-by: Corinna Vinschen Diff: --- newlib/libc/stdio/fputs.c | 2 -- newlib/libc/stdio/fputwc_u.c | 2 -- newlib/libc/stdio/fputws.c | 2 -- newlib/libc/stdio/fwrite.c | 2 -- newlib/libc/stdio/getc.c | 6 ------ newlib/libc/stdio/putc.c | 4 ---- newlib/libc/stdio/puts.c | 2 -- 7 files changed, 20 deletions(-) diff --git a/newlib/libc/stdio/fputs.c b/newlib/libc/stdio/fputs.c index a4f18df2af55..7437949433d4 100644 --- a/newlib/libc/stdio/fputs.c +++ b/newlib/libc/stdio/fputs.c @@ -115,8 +115,6 @@ _fputs_r (struct _reent * ptr, CHECK_INIT(ptr, fp); =20 _newlib_flockfile_start (fp); - if (ORIENT (fp, -1) !=3D -1) - goto error; /* Make sure we can write. */ if (cantwrite (ptr, fp)) goto error; diff --git a/newlib/libc/stdio/fputwc_u.c b/newlib/libc/stdio/fputwc_u.c index a5cc9a5d5817..7e7403b998eb 100644 --- a/newlib/libc/stdio/fputwc_u.c +++ b/newlib/libc/stdio/fputwc_u.c @@ -34,8 +34,6 @@ _fputwc_unlocked_r (struct _reent *ptr, wchar_t wc, FILE *fp) { - if (ORIENT(fp, 1) !=3D 1) - return WEOF; return __fputwc(ptr, wc, fp); } =20 diff --git a/newlib/libc/stdio/fputws.c b/newlib/libc/stdio/fputws.c index d6963837b4c7..f9fe4a4b324f 100644 --- a/newlib/libc/stdio/fputws.c +++ b/newlib/libc/stdio/fputws.c @@ -130,8 +130,6 @@ error: return (-1); #else _newlib_flockfile_start (fp); - if (ORIENT (fp, 1) !=3D 1) - goto error; if (cantwrite (ptr, fp) !=3D 0) goto error; =20 diff --git a/newlib/libc/stdio/fwrite.c b/newlib/libc/stdio/fwrite.c index 2d9749693b43..9241ea2cd997 100644 --- a/newlib/libc/stdio/fwrite.c +++ b/newlib/libc/stdio/fwrite.c @@ -152,8 +152,6 @@ _fwrite_r (struct _reent * ptr, CHECK_INIT (ptr, fp); =20 _newlib_flockfile_start (fp); - if (ORIENT (fp, -1) !=3D -1) - goto ret; /* Make sure we can write. */ if (cantwrite (ptr, fp)) goto ret; diff --git a/newlib/libc/stdio/getc.c b/newlib/libc/stdio/getc.c index 12bffaf8f79a..c8781320e603 100644 --- a/newlib/libc/stdio/getc.c +++ b/newlib/libc/stdio/getc.c @@ -81,9 +81,6 @@ _getc_r (struct _reent *ptr, { int result; CHECK_INIT (ptr, fp); - if (ORIENT (fp, -1) !=3D -1) - return EOF; - _newlib_flockfile_start (fp); result =3D __sgetc_r (ptr, fp); _newlib_flockfile_end (fp); @@ -99,9 +96,6 @@ getc (register FILE *fp) struct _reent *reent =3D _REENT; =20 CHECK_INIT (reent, fp); - if (ORIENT (fp, -1) !=3D -1) - return EOF; - _newlib_flockfile_start (fp); result =3D __sgetc_r (reent, fp); _newlib_flockfile_end (fp); diff --git a/newlib/libc/stdio/putc.c b/newlib/libc/stdio/putc.c index 925341939f7d..6a410e216df0 100644 --- a/newlib/libc/stdio/putc.c +++ b/newlib/libc/stdio/putc.c @@ -84,8 +84,6 @@ _putc_r (struct _reent *ptr, { int result; CHECK_INIT (ptr, fp); - if (ORIENT (fp, -1) !=3D -1) - return EOF; _newlib_flockfile_start (fp); result =3D __sputc_r (ptr, c, fp); _newlib_flockfile_end (fp); @@ -102,8 +100,6 @@ putc (int c, struct _reent *reent =3D _REENT; =20 CHECK_INIT (reent, fp); - if (ORIENT (fp, -1) !=3D -1) - return EOF; _newlib_flockfile_start (fp); result =3D __sputc_r (reent, c, fp); _newlib_flockfile_end (fp); diff --git a/newlib/libc/stdio/puts.c b/newlib/libc/stdio/puts.c index 20d889b81eea..d24022b4b36a 100644 --- a/newlib/libc/stdio/puts.c +++ b/newlib/libc/stdio/puts.c @@ -102,8 +102,6 @@ _puts_r (struct _reent *ptr, fp =3D _stdout_r (ptr); CHECK_INIT (ptr, fp); _newlib_flockfile_start (fp); - if (ORIENT (fp, -1) !=3D -1) - goto err; /* Make sure we can write. */ if (cantwrite (ptr, fp)) goto err;