From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2134) id B68D9385840D; Tue, 19 Dec 2023 19:00:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B68D9385840D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1703012415; bh=Am6FTEh0XGHgMblBZfDuL4NqW+4Tk78vJd4gy/805ik=; h=From:To:Subject:Date:From; b=CFGkWk3N44vEqwiA1eM1RSV9zdj5DiyKqqbIVy/aKNAPe8d3HBQYZnzQlAP/dnMiC sffnPIxpNVhef5C+evIS6hLVVy2h5o4OYKBY7RQotDlOjODy0UPwSa3zNPdxZKWj7K p6f6sElgG0lYwO5R27IQcOcl+Qd9ZyQwqnF9WrRc= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Jeff Johnston To: newlib-cvs@sourceware.org Subject: [newlib-cygwin] libgloss: drop $(INCLUDES) when using $(AS) X-Act-Checkin: newlib-cygwin X-Git-Author: Mike Frysinger X-Git-Refname: refs/heads/master X-Git-Oldrev: f81bf08f7caaebf877956d5d09c56a5d501de08a X-Git-Newrev: 751a3427e012b165086a4fd2da5981b0bbeaac07 Message-Id: <20231219190015.B68D9385840D@sourceware.org> Date: Tue, 19 Dec 2023 19:00:15 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3D751a3427e01= 2b165086a4fd2da5981b0bbeaac07 commit 751a3427e012b165086a4fd2da5981b0bbeaac07 Author: Mike Frysinger Date: Mon Dec 4 02:03:07 2023 -0500 libgloss: drop $(INCLUDES) when using $(AS) =20 Since $(AS) is the assembler, passing it a list of preprocessor include flags doesn't make much sense. The files aren't preprocessed which mea= ns `#include` lines aren't respected, and while it would affect `.include` usage, we never use that, and it's extremely unlikely to change. Plus, it's extremely unlikely we'd have .s files in common places to include = vs contained entirely within a specific arch dir, and at that point, it can be included directly (with no flags), or the arch can add the unique set of include paths that it needs for itself. Diff: --- libgloss/config/default.mh | 2 +- libgloss/config/ppc.mh | 2 +- libgloss/epiphany/Makefile.in | 2 +- libgloss/hp74x/Makefile.in | 2 +- libgloss/pru/Makefile.in | 2 +- libgloss/spu/Makefile.in | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libgloss/config/default.mh b/libgloss/config/default.mh index 81f0920f9..64dc02f05 100644 --- a/libgloss/config/default.mh +++ b/libgloss/config/default.mh @@ -14,7 +14,7 @@ AR_FLAGS =3D rc .C.o: $(CC) $(CFLAGS_FOR_TARGET) -O2 $(INCLUDES) -c $(CFLAGS) $< .s.o: - $(AS) $(ASFLAGS_FOR_TARGET) $(INCLUDES) $(ASFLAGS) -o $*.o $< + $(AS) $(ASFLAGS_FOR_TARGET) $(ASFLAGS) -o $*.o $< =20 # # GCC knows to run the preprocessor on .S files before it assembles them. diff --git a/libgloss/config/ppc.mh b/libgloss/config/ppc.mh index a3d157bb8..d1bfd7588 100644 --- a/libgloss/config/ppc.mh +++ b/libgloss/config/ppc.mh @@ -18,7 +18,7 @@ AR_FLAGS =3D qc .C.o: $(CC) $(CFLAGS_FOR_TARGET) $(CFLAGS_MRELOCATABLE) -O2 $(INCLUDES) -c $(CF= LAGS) $< .s.o: - $(AS) $(ASFLAGS_FOR_TARGET) $(INCLUDES) $(ASFLAGS) -o $*.o $< + $(AS) $(ASFLAGS_FOR_TARGET) $(ASFLAGS) -o $*.o $< =20 # # GCC knows to run the preprocessor on .S files before it assembles them. diff --git a/libgloss/epiphany/Makefile.in b/libgloss/epiphany/Makefile.in index 6cf55e25e..6670b79a0 100644 --- a/libgloss/epiphany/Makefile.in +++ b/libgloss/epiphany/Makefile.in @@ -105,7 +105,7 @@ AR_FLAGS =3D qc .S.o: $(CC) $(CFLAGS_FOR_TARGET) $(INCLUDES) -c $(CFLAGS) $< .s.o: - $(AS) $(ASFLAGS_FOR_TARGET) $(INCLUDES) $(ASFLAGS) -o $*.o $< + $(AS) $(ASFLAGS_FOR_TARGET) $(ASFLAGS) -o $*.o $< =20 # # GCC knows to run the preprocessor on .S files before it assembles them. diff --git a/libgloss/hp74x/Makefile.in b/libgloss/hp74x/Makefile.in index 12c51bf3b..0167e1c62 100644 --- a/libgloss/hp74x/Makefile.in +++ b/libgloss/hp74x/Makefile.in @@ -117,7 +117,7 @@ install: =20 .s.o: $(CC) $(CFLAGS_FOR_TARGET) $(INCLUDES) -c $< -# $(AS) $(CFLAGS_FOR_TARGET) $(INCLUDES) -c $< +# $(AS) $(CFLAGS_FOR_TARGET) -c $< =20 .SUFFIXES: .S .c .o .s .lif # diff --git a/libgloss/pru/Makefile.in b/libgloss/pru/Makefile.in index 7a2f290a8..fc5905a5e 100644 --- a/libgloss/pru/Makefile.in +++ b/libgloss/pru/Makefile.in @@ -89,7 +89,7 @@ LDFLAGS_FOR_TARGET =3D ${MULTILIB} .C.o: $(CC) $(CFLAGS_FOR_TARGET) -Os $(INCLUDES) -c $(CFLAGS) $< .s.o: - $(AS) $(ASFLAGS_FOR_TARGET) $(INCLUDES) $(ASFLAGS) -o $*.o $< + $(AS) $(ASFLAGS_FOR_TARGET) $(ASFLAGS) -o $*.o $< =20 # # GCC knows to run the preprocessor on .S files before it assembles them. diff --git a/libgloss/spu/Makefile.in b/libgloss/spu/Makefile.in index bc8768baf..4be0783b9 100644 --- a/libgloss/spu/Makefile.in +++ b/libgloss/spu/Makefile.in @@ -95,7 +95,7 @@ AR_FLAGS =3D qc .C.o: $(CC) $(CFLAGS_FOR_TARGET) -O2 $(INCLUDES) -c $(CFLAGS) $< .s.o: - $(AS) $(ASFLAGS_FOR_TARGET) $(INCLUDES) $(ASFLAGS) -o $*.o $< + $(AS) $(ASFLAGS_FOR_TARGET) $(ASFLAGS) -o $*.o $< =20 # # GCC knows to run the preprocessor on .S files before it assembles them.