public inbox for newlib-cvs@sourceware.org help / color / mirror / Atom feed
From: Jeff Law <law@sourceware.org> To: newlib-cvs@sourceware.org Subject: [newlib-cygwin] Fix various v850 problems Date: Wed, 20 Dec 2023 03:56:16 +0000 (GMT) [thread overview] Message-ID: <20231220035616.A1AEF3858439@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=c1a61029fedbad16bfd6978be13d62412bdede49 commit c1a61029fedbad16bfd6978be13d62412bdede49 Author: Jeff Law <jeffreyalaw@gmail.com> Date: Tue Dec 19 20:54:37 2023 -0700 Fix various v850 problems These fixes fall into a few different buckets. First c99 doesn't allow a parameter without a type. So in cases where the type had previously been an implicit int, make it an explicit int. Second, for return values, don't allow them to be implicit ints either, make them explicit. In a few cases change c89 function definitions to c99 function definitions. Lastly include <stdlib.h> in sbrk.c to get the prototype for abort () which we call when we detect a heap/stack collision. Diff: --- newlib/libc/sys/sysnecv850/_exit.c | 2 +- newlib/libc/sys/sysnecv850/getpid.c | 3 ++- newlib/libc/sys/sysnecv850/isatty.c | 4 ++-- newlib/libc/sys/sysnecv850/kill.c | 5 ++--- newlib/libc/sys/sysnecv850/read.c | 1 + newlib/libc/sys/sysnecv850/sbrk.c | 2 ++ 6 files changed, 10 insertions(+), 7 deletions(-) diff --git a/newlib/libc/sys/sysnecv850/_exit.c b/newlib/libc/sys/sysnecv850/_exit.c index 44d4132bd..7e1b09262 100644 --- a/newlib/libc/sys/sysnecv850/_exit.c +++ b/newlib/libc/sys/sysnecv850/_exit.c @@ -23,7 +23,7 @@ static void _do_dtors() } -void _exit (n) +void _exit (int n) { /* Destructors should be done earlier because they need to be done before the files are closed, but here is better than nowhere (and this balances the diff --git a/newlib/libc/sys/sysnecv850/getpid.c b/newlib/libc/sys/sysnecv850/getpid.c index 32ac7fbfb..f0fc4d895 100644 --- a/newlib/libc/sys/sysnecv850/getpid.c +++ b/newlib/libc/sys/sysnecv850/getpid.c @@ -9,7 +9,8 @@ int __trap0 (int function, int p1, int p2, int p3); #define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3)) -_getpid (n) +int +_getpid (int n) { return 1; } diff --git a/newlib/libc/sys/sysnecv850/isatty.c b/newlib/libc/sys/sysnecv850/isatty.c index 248ab5248..6e4f205f0 100644 --- a/newlib/libc/sys/sysnecv850/isatty.c +++ b/newlib/libc/sys/sysnecv850/isatty.c @@ -9,8 +9,8 @@ int __trap0 (int function, int p1, int p2, int p3); #define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3)) -_isatty (fd) - int fd; +int +_isatty (int fd) { return 1; } diff --git a/newlib/libc/sys/sysnecv850/kill.c b/newlib/libc/sys/sysnecv850/kill.c index 34e5db793..562eaf6c7 100644 --- a/newlib/libc/sys/sysnecv850/kill.c +++ b/newlib/libc/sys/sysnecv850/kill.c @@ -10,9 +10,8 @@ int __trap0 (int function, int p1, int p2, int p3); #define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3)) -_kill (pid, sig) - pid_t pid; - int sig; +int +_kill (pid_t pid, int sig) { return TRAP0 (SYS_exit, 0xdead0000 | sig, 0, 0); } diff --git a/newlib/libc/sys/sysnecv850/read.c b/newlib/libc/sys/sysnecv850/read.c index b55d1cb9e..5ae2c9799 100644 --- a/newlib/libc/sys/sysnecv850/read.c +++ b/newlib/libc/sys/sysnecv850/read.c @@ -9,6 +9,7 @@ int __trap0 (int function, int p1, int p2, int p3); #define TRAP0(f, p1, p2, p3) __trap0(f, (int)(p1), (int)(p2), (int)(p3)) +int _read (int file, char *ptr, int len) diff --git a/newlib/libc/sys/sysnecv850/sbrk.c b/newlib/libc/sys/sysnecv850/sbrk.c index 2893c322f..b5673d467 100644 --- a/newlib/libc/sys/sysnecv850/sbrk.c +++ b/newlib/libc/sys/sysnecv850/sbrk.c @@ -2,7 +2,9 @@ #include <sys/types.h> #include <sys/stat.h> #include "sys/syscall.h" +#include <stdlib.h> +extern int _write (int, char *, int); caddr_t _sbrk (int incr) {
reply other threads:[~2023-12-20 3:56 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231220035616.A1AEF3858439@sourceware.org \ --to=law@sourceware.org \ --cc=newlib-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).