public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jeff Law <law@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Re: libgloss c99 fixes for mn10300-elf
Date: Thu, 21 Dec 2023 07:02:27 +0000 (GMT)	[thread overview]
Message-ID: <20231221070227.A07983875468@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=7a45daad9184e30c336f27b3e54b9c5bcc2d3f77

commit 7a45daad9184e30c336f27b3e54b9c5bcc2d3f77
Author: Jeff Law <jeffreyalaw@gmail.com>
Date:   Thu Dec 21 00:01:54 2023 -0700

    Re: libgloss c99 fixes for mn10300-elf
    
    Very similar to other patches in this space.  Avoid implicit int types and add
    missing #includes so that this code works with gcc-14.

Diff:
---
 libgloss/mn10300/_exit.c  | 2 +-
 libgloss/mn10300/getpid.c | 3 ++-
 libgloss/mn10300/isatty.c | 4 ++--
 libgloss/mn10300/kill.c   | 3 ++-
 libgloss/mn10300/read.c   | 1 +
 libgloss/mn10300/sbrk.c   | 3 +++
 libgloss/mn10300/test.c   | 2 ++
 7 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/libgloss/mn10300/_exit.c b/libgloss/mn10300/_exit.c
index ec51d4088..2b548e82e 100644
--- a/libgloss/mn10300/_exit.c
+++ b/libgloss/mn10300/_exit.c
@@ -18,7 +18,7 @@ static void _do_dtors()
 }
 
 
-void _exit (n)
+void _exit (int n)
 {
   /* Destructors should be done earlier because they need to be done before the
      files are closed, but here is better than nowhere (and this balances the
diff --git a/libgloss/mn10300/getpid.c b/libgloss/mn10300/getpid.c
index 20ab1866e..fea57daff 100644
--- a/libgloss/mn10300/getpid.c
+++ b/libgloss/mn10300/getpid.c
@@ -4,7 +4,8 @@
 #include "trap.h"
 
 
-_getpid (n)
+int
+_getpid (int n)
 {
   return 1;
 }
diff --git a/libgloss/mn10300/isatty.c b/libgloss/mn10300/isatty.c
index 7e63a8c7c..3d8eb1910 100644
--- a/libgloss/mn10300/isatty.c
+++ b/libgloss/mn10300/isatty.c
@@ -4,8 +4,8 @@
 #include "trap.h"
 
 
-_isatty (fd)
-     int fd;
+int
+_isatty (int fd)
 {
   return 1;
 }
diff --git a/libgloss/mn10300/kill.c b/libgloss/mn10300/kill.c
index 40afa6a2c..d63a2f82c 100644
--- a/libgloss/mn10300/kill.c
+++ b/libgloss/mn10300/kill.c
@@ -4,7 +4,8 @@
 #include "trap.h"
 
 
-_kill (n, m)
+int
+_kill (int n, int m)
 {
   return TRAP0 (SYS_exit, 0xdead, 0, 0);
 }
diff --git a/libgloss/mn10300/read.c b/libgloss/mn10300/read.c
index 31d24cce9..2f1878c06 100644
--- a/libgloss/mn10300/read.c
+++ b/libgloss/mn10300/read.c
@@ -4,6 +4,7 @@
 #include "trap.h"
 
 
+int
 _read (int file,
        char *ptr,
        size_t len)
diff --git a/libgloss/mn10300/sbrk.c b/libgloss/mn10300/sbrk.c
index 376fd3285..78945e77a 100644
--- a/libgloss/mn10300/sbrk.c
+++ b/libgloss/mn10300/sbrk.c
@@ -1,8 +1,11 @@
 #include <_ansi.h>
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <stdlib.h>
 #include "trap.h"
 
+extern int _write (int, char *, size_t);
+
 
 caddr_t
 _sbrk (size_t incr)
diff --git a/libgloss/mn10300/test.c b/libgloss/mn10300/test.c
index 9ea873adf..a61dbb797 100644
--- a/libgloss/mn10300/test.c
+++ b/libgloss/mn10300/test.c
@@ -1,4 +1,6 @@
 #include <stdio.h>
+#include <unistd.h>
+#include <string.h>
 
 static void
 send_msg1 (void)

                 reply	other threads:[~2023-12-21  7:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231221070227.A07983875468@sourceware.org \
    --to=law@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).