public inbox for newlib-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@sourceware.org>
To: newlib-cvs@sourceware.org
Subject: [newlib-cygwin] Optimize strpbrk.c
Date: Thu, 21 Dec 2023 19:05:05 +0000 (GMT)	[thread overview]
Message-ID: <20231221190505.316C63858D37@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=188ca64934e610666bd05186395429bb2407c264

commit 188ca64934e610666bd05186395429bb2407c264
Author: Jeff Johnston <jjohnstn@redhat.com>
Date:   Thu Dec 21 14:04:31 2023 -0500

    Optimize strpbrk.c

Diff:
---
 newlib/libc/string/strpbrk.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/newlib/libc/string/strpbrk.c b/newlib/libc/string/strpbrk.c
index 774db1e6d..d98474564 100644
--- a/newlib/libc/string/strpbrk.c
+++ b/newlib/libc/string/strpbrk.c
@@ -29,23 +29,16 @@ strpbrk (const char *s1,
 	const char *s2)
 {
   const char *c = s2;
-  if (!*s1)
-    return (char *) NULL;
 
   while (*s1)
     {
       for (c = s2; *c; c++)
 	{
 	  if (*s1 == *c)
-	    break;
+	    return (char *) s1;
 	}
-      if (*c)
-	break;
       s1++;
     }
 
-  if (*c == '\0')
-    s1 = NULL;
-
-  return (char *) s1;
+  return (char *) NULL;
 }

                 reply	other threads:[~2023-12-21 19:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231221190505.316C63858D37@sourceware.org \
    --to=jjohnstn@sourceware.org \
    --cc=newlib-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).